* [NET-NEXT PATCH] igb: use dev_printk instead of printk
@ 2008-11-18 2:06 Jeff Kirsher
2008-11-20 8:48 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Kirsher @ 2008-11-18 2:06 UTC (permalink / raw)
To: davem; +Cc: netdev, jeff, Bjorn Helgaas, Jeff Kirsher
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
Use dev_printk() instead of printk() to give a little more context
and use consistent format.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/igb/igb_main.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c
index b1530be..b52626a 100644
--- a/drivers/net/igb/igb_main.c
+++ b/drivers/net/igb/igb_main.c
@@ -1019,10 +1019,9 @@ static int __devinit igb_probe(struct pci_dev *pdev,
state &= ~PCIE_LINK_STATE_L0S;
pci_write_config_word(us_dev, pos + PCI_EXP_LNKCTL,
state);
- printk(KERN_INFO "Disabling ASPM L0s upstream switch "
- "port %x:%x.%x\n", us_dev->bus->number,
- PCI_SLOT(us_dev->devfn),
- PCI_FUNC(us_dev->devfn));
+ dev_info(&pdev->dev,
+ "Disabling ASPM L0s upstream switch port %s\n",
+ pci_name(us_dev));
}
default:
break;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [NET-NEXT PATCH] igb: use dev_printk instead of printk
2008-11-18 2:06 [NET-NEXT PATCH] igb: use dev_printk instead of printk Jeff Kirsher
@ 2008-11-20 8:48 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-11-20 8:48 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, jeff, bjorn.helgaas
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 17 Nov 2008 18:06:35 -0800
> From: Bjorn Helgaas <bjorn.helgaas@hp.com>
>
> Use dev_printk() instead of printk() to give a little more context
> and use consistent format.
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Already applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-20 8:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-18 2:06 [NET-NEXT PATCH] igb: use dev_printk instead of printk Jeff Kirsher
2008-11-20 8:48 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).