From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 08/13] dmatest: convert to dma_request_channel Date: Tue, 18 Nov 2008 12:58:40 -0800 Message-ID: <20081118125840.e3c7745d.akpm@linux-foundation.org> References: <20081114213300.32354.1154.stgit@dwillia2-linux.ch.intel.com> <20081114213458.32354.58258.stgit@dwillia2-linux.ch.intel.com> <20081114221704.fe9ea599.akpm@linux-foundation.org> <1227032661.15042.10.camel@dwillia2-linux.ch.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, maciej.sosnowski@intel.com, hskinnemoen@atmel.com, g.liakhovetski@gmx.de, nicolas.ferre@atmel.com To: Dan Williams Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:43131 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752760AbYKRU6t (ORCPT ); Tue, 18 Nov 2008 15:58:49 -0500 In-Reply-To: <1227032661.15042.10.camel@dwillia2-linux.ch.intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 18 Nov 2008 11:24:21 -0700 Dan Williams wrote: > Ok, so I now have: > # git shortlog `stg id akpm-review-spell-fixes.patch`^.. > Dan Williams (6): > dmaengine review: spelling/grammar fixes > dmaengine review: dma_wait_for_async_tx clarification > dmaengine review: fix up kernel doc for dma_list_mutex usage > dmaengine review: propagate alloc_chan_resources error code > dmaengine review: return meaningful error code from initcall > dmaengine review: dmatest stop on dmatest_add_channel failure > > May I add your Reviewed-by for these and the original 13. Sure. Ignorantly-stared-at-by: would be more appropriate though. > I could fold > these into the originals but perhaps it is better to document fixups > when they are the result of review [1]. I think that a clean commit trail is more important. One can always retain documentation/attributions/etc in the changelog when folding.