From: David Miller <davem@davemloft.net>
To: dada1@cosmosbay.com
Cc: netdev@vger.kernel.org
Subject: Re: [RFC] question about inet_listen_lock(), and [PATCH] net: listening_hash get a spinlock per bucket
Date: Wed, 19 Nov 2008 15:41:53 -0800 (PST) [thread overview]
Message-ID: <20081119.154153.233063184.davem@davemloft.net> (raw)
In-Reply-To: <492199FF.3030205@cosmosbay.com>
From: Eric Dumazet <dada1@cosmosbay.com>
Date: Mon, 17 Nov 2008 17:21:19 +0100
> I was looking at converting tcp ehash/listening_hash rwlocks to spinlocks, and found
> inet_listen_lock()/unlock() definition :
I've known about this weird "bump a counter and sleep" locking thing we do
for listening sockets, but I haven't been able yet to track down the history
and understand why we do this.
There really was a reason, and your suspicion about /proc/net/tcp might be
correct, and of course doesn't really apply these days.
But I don't know for sure yet, and I'd rather not apply thing until I do.
Give me some more time to do the history search, thanks.
next prev parent reply other threads:[~2008-11-19 23:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-17 16:21 [RFC] question about inet_listen_lock(), and [PATCH] net: listening_hash get a spinlock per bucket Eric Dumazet
2008-11-19 23:41 ` David Miller [this message]
2008-11-20 8:41 ` David Miller
2008-11-20 8:47 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081119.154153.233063184.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dada1@cosmosbay.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).