From: Rusty Russell <rusty@rustcorp.com.au>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] net: make ip_rt_acct a normal percpu var
Date: Wed, 19 Nov 2008 02:08:10 +1030 [thread overview]
Message-ID: <200811190208.11346.rusty@rustcorp.com.au> (raw)
In-Reply-To: <4921F1DE.9080305@cosmosbay.com>
On Tuesday 18 November 2008 09:06:14 Eric Dumazet wrote:
> Rusty Russell a écrit :
> > There's no reason for this to be dynamically allocated: we panic if
> > allocation fails anyway.
> >
> > Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>
> Well, since we dont have "per_cpu bss", this also grow the size of vmlinux
> file, with a block of 4096 nul bytes.
...
> Maybe with current machines/boot loaders, we dont care anymore, I dont
> know...
Good q. If people care about on-disk size, maybe we should look at bzImage
size?
Anyway, here 'tis:
Before:
text data bss dec hex filename
4116153 433292 475136 5024581 4cab45 vmlinux
-rw-r--r-- 1 rusty rusty 2251984 2008-11-19 02:03 arch/x86/boot/bzImage
After:
text data bss dec hex filename
4116089 437388 475136 5028613 4cbb05 vmlinux
-rw-r--r-- 1 rusty rusty 2252016 2008-11-19 02:05 arch/x86/boot/bzImage
Cheers,
Rusty.
next prev parent reply other threads:[~2008-11-18 15:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-17 10:20 [PATCH] net: make ip_rt_acct a normal percpu var Rusty Russell
2008-11-17 22:36 ` Eric Dumazet
2008-11-18 15:38 ` Rusty Russell [this message]
2008-11-19 22:20 ` David Miller
2008-11-19 23:13 ` Rusty Russell
2008-11-19 23:17 ` David Miller
2008-11-20 4:22 ` Rusty Russell
2008-11-19 23:23 ` Eric Dumazet
2008-11-20 0:28 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811190208.11346.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).