Re: [PATCH 30/33] tg3: convert to net_device_ops

[Stephen Hemminger <shemminger@vyatta.com>]

On Wed, 19 Nov 2008 13:04:47 -0800
"Matt Carlson" <mcarlson@broadcom.com> wrote:

> On Mon, Nov 17, 2008 at 05:37:06PM -0800, Stephen Hemminger wrote:
> > Convert this driver to network device ops.
> > 
> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> > 
> > ---
> > Handle non-vlan build.
> > 
> > --- a/drivers/net/tg3.c	2008-11-17 17:21:58.000000000 -0800
> > +++ b/drivers/net/tg3.c	2008-11-17 17:26:45.000000000 -0800
> > @@ -13343,6 +13343,24 @@ static void __devinit tg3_init_coal(stru
> >  	}
> >  }
> >  
> > +static const struct net_device_ops tg3_netdev_ops = {
> > +	.open			= tg3_open,
> > +	.stop			= tg3_close,
> 
> One more completely trivial nit.  Is there a reason why you chose
> the verbs to be "open" and "stop" rather than "open" and "close" or
> "start" and "stop"?

Because that is what they were before (but in a different place).