From: David Miller <davem@davemloft.net>
To: randy.dunlap@oracle.com
Cc: bhutchings@solarflare.com, netdev@vger.kernel.org,
linux-net-drivers@solarflare.com, dwmw2@infradead.org,
sfr@canb.auug.org.au, linux-next@vger.kernel.org
Subject: Re: [PATCH] sfc: Fix dependency for SFC_MTD
Date: Thu, 20 Nov 2008 04:17:53 -0800 (PST) [thread overview]
Message-ID: <20081120.041753.264904694.davem@davemloft.net> (raw)
In-Reply-To: <4924872E.5070102@oracle.com>
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Wed, 19 Nov 2008 13:37:50 -0800
> Ben Hutchings wrote:
> > Randy Dunlap found that SFC_MTD was selected when sfc was built-in and
> > the MTD core was a module. Don't allow that combination.
> >
> > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
>
> Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
>
> I realized that this problem came up because SFC_MTD is a boolean
> that depends on tristates, so the boolean is set (=y) when
> SFC=y or SFC=m. Thus extra handling for it is needed,
> like Ben did here.
Applied, thanks everyone.
prev parent reply other threads:[~2008-11-20 12:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 20:48 [PATCH] sfc: Fix dependency for SFC_MTD Ben Hutchings
2008-11-19 20:53 ` Ben Hutchings
2008-11-19 21:37 ` Randy Dunlap
2008-11-20 12:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081120.041753.264904694.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=dwmw2@infradead.org \
--cc=linux-net-drivers@solarflare.com \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).