From: David Miller <davem@davemloft.net>
To: apetlund@simula.no
Cc: netdev@vger.kernel.org
Subject: Re: pci: Added quirk to disable msi for MCP55 NIC on Asus P5N32-SLI Premium
Date: Thu, 20 Nov 2008 20:42:41 -0800 (PST) [thread overview]
Message-ID: <20081120.204241.166232434.davem@davemloft.net> (raw)
In-Reply-To: <492574FC.2090701@simula.no>
From: Andreas Petlund <apetlund@simula.no>
Date: Thu, 20 Nov 2008 15:32:28 +0100
> David Miller wrote:
> > You can't start calling dmi_*() routines in drivers/pci/quirks.c without
> > including linux/dmi.h there, otherwise it doesn't build on some platforms:
> >
> > drivers/pci/quirks.c: In function 'nvenet_msi_disable':
> > drivers/pci/quirks.c:1837: error: implicit declaration of function 'dmi_name_in_vendors'
> > make[1]: *** [drivers/pci/quirks.o] Error 1
>
> Here is an updated version with the missing include.
>
> Signed-off-by: Andreas Petlund <andreas@petlund.no>
Applied, thanks.
next prev parent reply other threads:[~2008-11-21 4:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 22:13 pci: Added quirk to disable msi for MCP55 NIC on Asus P5N32-SLI Premium David Miller
2008-11-20 14:32 ` Andreas Petlund
2008-11-21 4:42 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-11-16 9:53 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081120.204241.166232434.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=apetlund@simula.no \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).