From: Stephen Hemminger <shemminger@vyatta.com>
To: cooldavid@cooldavid.org, David Miller <davem@davemloft.net>
Cc: Jeff Garzik <jgarzik@pobox.com>,
netdev@vger.kernel.org, Ethan <ethanhsiao@jmicron.com>,
akeemting <akeem@jmicron.com>
Subject: Re: [PATCH netdev-2.6] jme: JMicron Gigabit Ethernet Driver
Date: Thu, 20 Nov 2008 21:20:45 -0800 [thread overview]
Message-ID: <20081120212045.27879d22@extreme> (raw)
In-Reply-To: <20080915165101.M68109@cooldavid.org>
Going through this driver for net_device_ops makes me wonder
why some other things wer not caught during the review process.
1. Obfuscation by macro which looks like some "vendor support older kernels"
stuff. See the wrapping of NAPI and NET_STAT
2. 5 tasklets for thing that could be done by NAPI and one tasklet
3. 4 atomic variables for things that should be already covered by locks
4. 3 locks, seems like more than needed.
5. PCI setup of max read request size should be done via pci_set_readrq
not by direct manipulation of PCI registers.
6. Not using pci dma allocation which is more standard convention
7. NAPI weight is very large 256 (vs normal 64)
next prev parent reply other threads:[~2008-11-21 5:20 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-15 17:00 [PATCH netdev-2.6] jme: JMicron Gigabit Ethernet Driver Guo-Fu Tseng
2008-09-16 2:47 ` Ethan
2008-09-18 16:07 ` Jeff Garzik
2008-10-08 21:56 ` [PATCH net-next-2.6 1/3] jme: Added half-duplex mode and IPv6 RSS fix Guo-Fu Tseng
2008-10-09 2:51 ` David Miller
2008-10-08 21:57 ` [PATCH net-next-2.6 2/3] jme: Faulty IRQ handle bug fix Guo-Fu Tseng
2008-10-09 2:51 ` David Miller
2008-10-08 21:58 ` [PATCH net-next-2.6 3/3] jme: Advances version number Guo-Fu Tseng
2008-10-09 2:51 ` David Miller
2008-12-03 10:41 ` [PATCH net-2.6 1/2] jme: GHC register control fix for new hardware Guo-Fu Tseng
2008-12-03 15:00 ` Jeff Garzik
2008-12-04 5:20 ` David Miller
2008-12-03 10:44 ` [PATCH net-2.6 2/2] jme: Remove 64 and 40 bit dma_mask Guo-Fu Tseng
2009-02-28 3:54 ` [PATCH net-next-2.6 1/4] jme: Modifies messages to display correct hardware version Guo-Fu Tseng
2009-02-28 3:57 ` [PATCH net-next-2.6 2/4] jme: Fix pci sync Guo-Fu Tseng
2009-02-28 3:58 ` [PATCH net-next-2.6 3/4] jme: Clear all modified GHC register flags Guo-Fu Tseng
2009-02-28 3:59 ` [PATCH net-next-2.6 4/4] jme: Adding {64,40}bits DMA mask back Guo-Fu Tseng
2009-03-02 8:39 ` [PATCH net-next] jme: Advance version number after previous changes Guo-Fu Tseng
2009-03-02 9:55 ` David Miller
2008-11-21 5:20 ` Stephen Hemminger [this message]
2008-11-21 5:36 ` [PATCH netdev-2.6] jme: JMicron Gigabit Ethernet Driver David Miller
2008-11-21 6:45 ` Stephen Hemminger
2008-11-21 8:46 ` David Miller
2008-11-21 16:22 ` Guo-Fu Tseng
2008-11-21 16:18 ` Guo-Fu Tseng
-- strict thread matches above, loose matches on Subject: below --
2008-08-23 6:05 Guo-Fu Tseng
2008-08-23 6:41 ` Jeff Garzik
2008-08-23 16:04 ` Guo-Fu Tseng
2008-08-25 16:21 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081120212045.27879d22@extreme \
--to=shemminger@vyatta.com \
--cc=akeem@jmicron.com \
--cc=cooldavid@cooldavid.org \
--cc=davem@davemloft.net \
--cc=ethanhsiao@jmicron.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).