Re: [NET-NEXT v4 PATCH 1/5] ixgbe: this patch adds support for DCB to the kernel and ixgbe driver

[David Miller <davem@davemloft.net>]

From: Wang Chen <wangchen@cn.fujitsu.com>
Date: Fri, 21 Nov 2008 17:14:16 +0800

> Jeff Kirsher said the following on 2008-11-21 10:00:
> > diff --git a/drivers/net/ixgbe/ixgbe_ethtool.c b/drivers/net/ixgbe/ixgbe_ethtool.c
> > index a610016..aaa4404 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethtool.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethtool.c
> > @@ -97,9 +97,18 @@ static struct ixgbe_stats ixgbe_gstrings_stats[] = {
> >  	((((struct ixgbe_adapter *)netdev_priv(netdev))->num_tx_queues + \
> >  	((struct ixgbe_adapter *)netdev_priv(netdev))->num_rx_queues) * \
> >  	(sizeof(struct ixgbe_queue_stats) / sizeof(u64)))
> > -#define IXGBE_STATS_LEN (IXGBE_GLOBAL_STATS_LEN + IXGBE_QUEUE_STATS_LEN)
> >  #define IXGBE_GLOBAL_STATS_LEN ARRAY_SIZE(ixgbe_gstrings_stats)
> > -#define IXGBE_STATS_LEN (IXGBE_GLOBAL_STATS_LEN + IXGBE_QUEUE_STATS_LEN)
> > +#define IXGBE_PB_STATS_LEN ( \
> > +                 (((struct ixgbe_adapter *)netdev->priv)->flags & \
> 
> Dave, please don't hate me. :)
> I know you've applied it.
> But I don't want this directly reference of netdev->priv.

Send me a patch!