Re: [NET-NEXT PATCH 14/14] e1000e: check return code from NVM accesses and fix bank detection

[David Miller <davem@davemloft.net>]

From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Fri, 21 Nov 2008 11:02:56 -0800

> From: Bruce Allan <bruce.w.allan@intel.com>
> 
> Check return code for all NVM accesses[1] and error out accordingly; log
> a debug message for failed accesses.
> 
> For ICH8/9, the valid NVM bank detect function was not checking whether the
> SEC1VAL (sector 1 valid) bit in the EECD register was itself valid (bits 8
> and 9 also have to be set).  If invalid, it would have defaulted to the
> possibly invalid bank 0.  Instead, try to use the valid bank detection
> method used by ICH10 which has been cleaned up a bit.
> 
> [1] - reads and updates only; not writes because those are only writing to
> the Shadow RAM, the update following the write is the only thing actually
> writing the modified Shadow RAM contents to the NVM.
> 
> Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>

Applied.

Thanks.