From: David Miller <davem@davemloft.net>
To: mcarlson@broadcom.com
Cc: netdev@vger.kernel.org, mchan@broadcom.com, andy@greyhouse.net
Subject: Re: [PATCH 01/10] tg3: Use NET_IP_ALIGN
Date: Fri, 21 Nov 2008 17:16:25 -0800 (PST) [thread overview]
Message-ID: <20081121.171625.143644175.davem@davemloft.net> (raw)
In-Reply-To: <1227295575.5612@xw6200>
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Fri, 21 Nov 2008 10:59:42 -0800
> This patch replaces hardcoded 2's with the NET_IP_ALIGN constant or
> TG3_RAW_IP_ALIGN where appropriate. Some platforms can redefine the
> NET_IP_ALIGN definition to zero if unaligned DMA transfers cost more
> than the IP header alignment gains. This patch represents a
> performance improvement when using the 5701 on these platforms.
> The copy path can be avoided.
>
> TG3_RAW_IP_ALIGN is used in cases where we always want to align the
> IP header on dword boundaries.
>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied.
prev parent reply other threads:[~2008-11-22 1:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 18:59 [PATCH 01/10] tg3: Use NET_IP_ALIGN Matt Carlson
2008-11-22 1:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081121.171625.143644175.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).