netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: "David S. Miller" <davem@davemloft.net>,
	Linux Netdev List <netdev@vger.kernel.org>
Subject: [PATCH] Re: pkt_sched: add DRR scheduler
Date: Fri, 21 Nov 2008 12:19:49 +0000	[thread overview]
Message-ID: <20081121121949.GA13892@ff.dom.local> (raw)
In-Reply-To: <49254D42.10506@trash.net>

A small oversight:
----------------->
pkt_sched: sch_drr: Fix qlen in drr_drop()

Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
---

 net/sched/sch_drr.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/sched/sch_drr.c b/net/sched/sch_drr.c
index 8d523d9..37e6ab9 100644
--- a/net/sched/sch_drr.c
+++ b/net/sched/sch_drr.c
@@ -406,6 +406,7 @@ static unsigned int drr_drop(struct Qdisc *sch)
 		if (cl->qdisc->ops->drop) {
 			len = cl->qdisc->ops->drop(cl->qdisc);
 			if (len > 0) {
+				sch->q.qlen--;
 				if (cl->qdisc->q.qlen == 0)
 					list_del(&cl->alist);
 				return len;

  parent reply	other threads:[~2008-11-21 12:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-19 14:26 pkt_sched: add DRR scheduler Patrick McHardy
2008-11-20 11:35 ` Jarek Poplawski
2008-11-20 11:42   ` Patrick McHardy
2008-11-20 11:51     ` Jarek Poplawski
2008-11-20 11:58       ` Patrick McHardy
2008-11-20 12:06         ` Jarek Poplawski
2008-11-20 12:10     ` David Miller
2008-11-21 12:19     ` Jarek Poplawski [this message]
2008-11-21 12:36       ` [PATCH] " Patrick McHardy
2008-11-21 12:37         ` David Miller
2008-11-24 10:50     ` [PATCH] pkt_sched: sch_drr: Fix drr_dequeue() loop Jarek Poplawski
2008-11-24 10:53     ` [PATCH v2] " Jarek Poplawski
2008-11-24 12:15       ` Patrick McHardy
2008-11-24 12:33         ` Jarek Poplawski
2008-11-24 12:38           ` Patrick McHardy
2008-11-24 12:51             ` Jarek Poplawski
2008-11-24 13:17               ` Patrick McHardy
2008-11-24 13:45                 ` Jarek Poplawski
2008-11-24 23:47                   ` David Miller
2008-11-25 11:42                     ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081121121949.GA13892@ff.dom.local \
    --to=jarkao2@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).