From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 01/10] x86: add Kconfig entry for DMA-API debugging Date: Fri, 21 Nov 2008 17:48:55 +0100 Message-ID: <20081121164855.GB1386@amd.com> References: <1227284770-19215-1-git-send-email-joerg.roedel@amd.com> <1227284770-19215-2-git-send-email-joerg.roedel@amd.com> <20081121164014.GB733@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Ingo Molnar , Thomas Gleixner , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, iommu@lists.linux-foundation.org To: Ingo Molnar Return-path: Received: from outbound-dub.frontbridge.com ([213.199.154.16]:54696 "EHLO IE1EHSOBE005.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752609AbYKUQtW (ORCPT ); Fri, 21 Nov 2008 11:49:22 -0500 Content-Disposition: inline In-Reply-To: <20081121164014.GB733@elte.hu> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Nov 21, 2008 at 05:40:14PM +0100, Ingo Molnar wrote: > > * Joerg Roedel wrote: > > > +config DMA_API_DEBUG > > + default n > > 'default n' can be omitted in general from interactive Kconfig > entries. Ok, then I remove it. > > > + bool "Enable debugging of DMA-API usage" > > + depends on X86 > > perhaps add a proper dependency on iommu or swiotlb presence as well - > in case we decide to make it all disable-able again and dont have the > callbacks present? No problem. But its hard to believe that we make the DMA-API disable-able some day ;) The best dependency in this case should be SWIOTLB I think. Joerg -- | AMD Saxony Limited Liability Company & Co. KG Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany System | Register Court Dresden: HRA 4896 Research | General Partner authorized to represent: Center | AMD Saxony LLC (Wilmington, Delaware, US) | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy