From: Ingo Molnar <mingo@elte.hu>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
netdev@vger.kernel.org, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/10] DMA-API debugging facility
Date: Fri, 21 Nov 2008 18:03:21 +0100 [thread overview]
Message-ID: <20081121170321.GH733@elte.hu> (raw)
In-Reply-To: <20081121165722.GD1386@amd.com>
* Joerg Roedel <joerg.roedel@amd.com> wrote:
> On Fri, Nov 21, 2008 at 04:54:52PM +0000, David Woodhouse wrote:
> > On Fri, 2008-11-21 at 17:26 +0100, Joerg Roedel wrote:
> > > this patchset introduces code to debug drivers usage of the DMA-API.
> > > Tests with hardware IOMMUs have shown several bugs in drivers
> > > regarding the usage of that API.
> > > Problems were found especially in network card drivers.
> >
> > This is really useful -- but surely it shouldn't be x86-specific?
> >
> > All the code except the hooks in the architecture's dma_map_single() et
> > al functions could be generic, couldn't it?
>
> Yes, in principle we could move most of it to generic code. There is
> nothing architecture specific in it. Anybody who prefers this to be
> arch/x86 before moving it to lib/?
yeah, we want to make it generic once it works.
but my comments about the allocation needs to be addressed (see my
comments on [03/10]), and solving that will likely impact the
structure of the approach in a way that will generalize it anyway, as
a side-effect.
Ingo
next prev parent reply other threads:[~2008-11-21 17:03 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 16:26 [PATCH 0/10] DMA-API debugging facility Joerg Roedel
2008-11-21 16:26 ` [PATCH 01/10] x86: add Kconfig entry for DMA-API debugging Joerg Roedel
2008-11-21 16:40 ` Ingo Molnar
2008-11-21 16:48 ` Joerg Roedel
2008-11-21 23:18 ` David Miller
2008-11-21 16:26 ` [PATCH 02/10] x86: add data structures " Joerg Roedel
2008-11-21 16:42 ` Ingo Molnar
2008-11-21 16:49 ` Joerg Roedel
2008-11-21 16:26 ` [PATCH 03/10] x86: add initialization code " Joerg Roedel
2008-11-21 16:56 ` Ingo Molnar
2008-11-21 17:10 ` Joerg Roedel
2008-11-21 17:19 ` Ingo Molnar
2008-11-21 17:27 ` Ingo Molnar
2008-11-21 17:43 ` Ingo Molnar
2008-11-22 9:48 ` Joerg Roedel
2008-11-23 11:28 ` Ingo Molnar
2008-11-23 11:35 ` Ingo Molnar
2008-11-23 13:04 ` Ingo Molnar
2008-11-22 3:27 ` FUJITA Tomonori
2008-11-22 9:40 ` Joerg Roedel
2008-11-22 10:16 ` FUJITA Tomonori
2008-11-22 12:28 ` FUJITA Tomonori
2008-11-23 19:36 ` Andi Kleen
2008-11-21 16:26 ` [PATCH 04/10] x86: add helper functions for consistency checks Joerg Roedel
2008-11-21 17:07 ` Ingo Molnar
2008-11-21 16:26 ` [PATCH 05/10] x86: add check code for map/unmap_single code Joerg Roedel
2008-11-22 3:27 ` FUJITA Tomonori
2008-11-22 9:39 ` Joerg Roedel
2008-11-21 16:26 ` [PATCH 06/10] x86: add check code for map/unmap_sg code Joerg Roedel
2008-11-21 16:58 ` Ingo Molnar
2008-11-21 17:10 ` Ingo Molnar
2008-11-21 16:26 ` [PATCH 07/10] x86: add checks for alloc/free_coherent code Joerg Roedel
2008-11-21 16:57 ` Ingo Molnar
2008-11-22 3:27 ` FUJITA Tomonori
2008-11-22 9:38 ` Joerg Roedel
2008-11-21 16:26 ` [PATCH 08/10] x86: add checks for sync_single* code Joerg Roedel
2008-11-21 16:26 ` [PATCH 09/10] x86: add checks for sync_single_range* code Joerg Roedel
2008-11-21 16:26 ` [PATCH 10/10] x86: add checks for sync_sg* code Joerg Roedel
2008-11-21 16:59 ` Ingo Molnar
2008-11-21 16:37 ` [PATCH 0/10] DMA-API debugging facility Ingo Molnar
2008-11-21 16:40 ` Joerg Roedel
2008-11-21 16:52 ` Joerg Roedel
2008-11-21 16:54 ` David Woodhouse
2008-11-21 16:57 ` Joerg Roedel
2008-11-21 17:03 ` Ingo Molnar [this message]
2008-11-21 17:06 ` David Woodhouse
2008-11-21 17:18 ` Ingo Molnar
2008-11-21 17:20 ` Joerg Roedel
2008-11-21 17:24 ` David Woodhouse
2008-11-21 17:27 ` Joerg Roedel
2008-11-21 17:45 ` Ingo Molnar
2008-11-22 3:27 ` FUJITA Tomonori
2008-11-22 9:33 ` Joerg Roedel
2008-11-22 10:16 ` FUJITA Tomonori
2009-02-05 22:44 ` David Woodhouse
2009-02-25 8:11 ` David Woodhouse
2009-07-01 13:19 ` [PATCH] Support DMA-API debugging facility on PowerPC David Woodhouse
2009-07-01 14:00 ` Christoph Hellwig
2009-07-01 18:34 ` Joerg Roedel
2009-07-02 14:09 ` Kumar Gala
2008-11-21 17:22 ` [PATCH 0/10] DMA-API debugging facility David Woodhouse
2008-11-22 3:27 ` FUJITA Tomonori
2008-11-22 9:29 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081121170321.GH733@elte.hu \
--to=mingo@elte.hu \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).