From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 0/10] DMA-API debugging facility Date: Fri, 21 Nov 2008 18:20:46 +0100 Message-ID: <20081121172046.GF1386@amd.com> References: <1227284770-19215-1-git-send-email-joerg.roedel@amd.com> <1227286492.4901.208.camel@macbook.infradead.org> <20081121165722.GD1386@amd.com> <1227287215.4901.213.camel@macbook.infradead.org> <20081121171802.GK733@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: David Woodhouse , Ingo Molnar , Thomas Gleixner , netdev@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org To: Ingo Molnar Return-path: Received: from outbound-sin.frontbridge.com ([207.46.51.80]:50046 "EHLO SG2EHSOBE005.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754631AbYKURVP (ORCPT ); Fri, 21 Nov 2008 12:21:15 -0500 Content-Disposition: inline In-Reply-To: <20081121171802.GK733@elte.hu> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Nov 21, 2008 at 06:18:02PM +0100, Ingo Molnar wrote: > > * David Woodhouse wrote: > > > On Fri, 2008-11-21 at 17:57 +0100, Joerg Roedel wrote: > > > Yes, in principle we could move most of it to generic code. There is > > > nothing architecture specific in it. > > > Anybody who prefers this to be arch/x86 before moving it to lib/? > > > > I think it's better to start off with a generic version, and test it > > on more than one architecture before feeding it upstream. That way, > > you know you aren't going to have to go back to the drawing board > > with it. > > Joerg, i'd suggest to make the generic conceptual bits generic, and > add an HAVE_DMA_DEBUG_SUPPORT Kconfig bool flag to every architecture > that enables it. It needs active changes to every architecture that > supports this facility. Ok, I will move the generic bits to lib/ and include/linux and let architectures decide if they want to use it. Joerg -- | AMD Saxony Limited Liability Company & Co. KG Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany System | Register Court Dresden: HRA 4896 Research | General Partner authorized to represent: Center | AMD Saxony LLC (Wilmington, Delaware, US) | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy