Re: [PATCH] net: gen_estimator: Fix gen_kill_estimator() lookups

[Jarek Poplawski <jarkao2@gmail.com>]

On Mon, Nov 24, 2008 at 08:18:45AM -0500, jamal wrote:
> On Mon, 2008-11-24 at 12:04 +0000, Jarek Poplawski wrote:
> > gen_kill_estimator() linear lists lookups are very slow, and e.g. while
> > deleting a large number of HTB classes soft lockups were reported. Here
> > is another try to fix this problem: this time internally, with rbtree,
> > so similarly to Jamal's hashing idea IIRC. (Looking for next hits could
> > be still optimized, but it's really fast as it is.)
> 
> Certainly a big improvement. Compared to hashing i suggested:
> the deletion speed is probably equal or better than using a hash.
> I think a hash would have performed better in the case of addition
> than the rb tree; but you primarily concerned about deletion, so this
> good.

I first thought about a hash, but alas Patrick's solution is sched
only... Anyway, I din't see too much overhead in memory use, and no
diffrence in addition times (without batching).

> 
> Acked-by: Jamal Hadi Salim <hadi@cyberus.ca>
> 

Thanks,
Jarek P.