From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: jarkao2@gmail.com, herbert@gondor.apana.org.au, netdev@vger.kernel.org
Subject: Re: [PATCH] pkt_sched: sch_api: Remove qdisc_list_lock
Date: Tue, 25 Nov 2008 13:56:22 -0800 (PST) [thread overview]
Message-ID: <20081125.135622.231076050.davem@davemloft.net> (raw)
In-Reply-To: <492BE591.8060202@trash.net>
From: Patrick McHardy <kaber@trash.net>
Date: Tue, 25 Nov 2008 12:46:25 +0100
> Patrick McHardy wrote:
> > Jarek Poplawski wrote:
> >> After implementing qdisc->ops->peek() there is no more calling
> >> qdisc_tree_decrease_qlen() without rtnl_lock(), so qdisc_list_lock
> >> added by commit: f6e0b239a2657ea8cb67f0d83d0bfdbfd19a481b "pkt_sched:
> >> Fix qdisc list locking" can be removed.
> > I might be misunderstanding something, but qdisc_tree_decrease_qlen()
> > doesn't need rtnl_lock() but the sch_tree_lock() since it changes
> > q.qlen.
>
> OK I see now, rtnl_lock() was taken to protect the parent qdisc lookup.
> In that case it seems fine, all callers are holding both sch_tree_lock()
> and rtnl_lock().
:-)
I've applied Jarek's patch.
Thanks!
prev parent reply other threads:[~2008-11-25 21:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 11:29 [PATCH] pkt_sched: sch_api: Remove qdisc_list_lock Jarek Poplawski
2008-11-25 11:44 ` Patrick McHardy
2008-11-25 11:46 ` Patrick McHardy
2008-11-25 21:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081125.135622.231076050.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jarkao2@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).