From: Stephen Hemminger <shemminger@vyatta.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: David Miller <davem@davemloft.net>,
randy.dunlap@oracle.com, netdev@vger.kernel.org,
jgarzik@pobox.com, akpm@linux-foundation.org
Subject: Re: [PATCH -next/-mm/mainline] net/hp-plus: fix link errors
Date: Tue, 25 Nov 2008 14:20:26 -0800 [thread overview]
Message-ID: <20081125142026.49ed9c02@extreme> (raw)
In-Reply-To: <20081125221328.6fc5a400@lxorguk.ukuu.org.uk>
On Tue, 25 Nov 2008 22:13:28 +0000
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > We added code that splits the struct netdev function pointers out into
> > a seperate structure. In order to make initialization of the
> > netdev_ops members work inside of the driver (and keep it const), we
> > exported some of these 8390 library symbols.
>
> Then probably they want __ sticking in front of them and wrapping in
> 8390.c and 8390p.c which is how the other symbols were done.
>
> Alan
Actually, all the 8390 based drivers need to get converted to netdev_ops
then it will be fixed.
prev parent reply other threads:[~2008-11-25 22:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 5:17 [PATCH -next/-mm/mainline] net/hp-plus: fix link errors Randy Dunlap
2008-11-22 0:33 ` David Miller
2008-11-25 17:59 ` Randy Dunlap
2008-11-25 18:18 ` Alan Cox
2008-11-25 21:41 ` David Miller
2008-11-25 22:13 ` Alan Cox
2008-11-25 22:20 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081125142026.49ed9c02@extreme \
--to=shemminger@vyatta.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).