From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH -next/-mm/mainline] net/hp-plus: fix link errors Date: Tue, 25 Nov 2008 14:20:26 -0800 Message-ID: <20081125142026.49ed9c02@extreme> References: <20081121.163335.255948683.davem@davemloft.net> <20081125095952.f25e8286.randy.dunlap@oracle.com> <20081125181800.7502d395@lxorguk.ukuu.org.uk> <20081125.134145.66227024.davem@davemloft.net> <20081125221328.6fc5a400@lxorguk.ukuu.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: David Miller , randy.dunlap@oracle.com, netdev@vger.kernel.org, jgarzik@pobox.com, akpm@linux-foundation.org To: Alan Cox Return-path: Received: from mail.vyatta.com ([76.74.103.46]:57842 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947AbYKYWUa (ORCPT ); Tue, 25 Nov 2008 17:20:30 -0500 In-Reply-To: <20081125221328.6fc5a400@lxorguk.ukuu.org.uk> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 25 Nov 2008 22:13:28 +0000 Alan Cox wrote: > > We added code that splits the struct netdev function pointers out into > > a seperate structure. In order to make initialization of the > > netdev_ops members work inside of the driver (and keep it const), we > > exported some of these 8390 library symbols. > > Then probably they want __ sticking in front of them and wrapping in > 8390.c and 8390p.c which is how the other symbols were done. > > Alan Actually, all the 8390 based drivers need to get converted to netdev_ops then it will be fixed.