netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: catab@embedromix.ro
Cc: jmack@wm7d.net, netdev@vger.kernel.org, lvs-devel@vger.kernel.org
Subject: Re: [PATCH] IPVS: Allow boot time change of hash size.
Date: Wed, 26 Nov 2008 23:37:58 -0800 (PST)	[thread overview]
Message-ID: <20081126.233758.235891402.davem@davemloft.net> (raw)
In-Reply-To: <41063.91.201.80.240.1227769550.squirrel@mail.embedromix.ro>

From: "Catalin(ux) M. BOIE" <catab@embedromix.ro>
Date: Thu, 27 Nov 2008 00:05:50 -0700 (MST)

> Do you mean that it should be computed based on memory size or you mean
> that it should be changeable on-the-fly, even when we have some
> connections in the tables already?

I mean the latter.  We do this in other subsystems, such as
IPSEC, for various hashes.

> Do you have some hints (where to look for a similar thing)?
> The thing that worries me a little is the locking around the move and
> maybe the latency involved. Yes, of course you will not change it several
> times per minute, but...

You only increase, never decrease.

A lock is held during every access to these hash tables, so
the locking should be very similar.

Have a look at xfrm_hash_resize() in net/xfrm/xfrm_state.c to get
a good idea on how this stuff can be done.  And hey, that code
resizes 3 tables at once, you only need to handle one :)

  reply	other threads:[~2008-11-27  7:37 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-26 13:36 [PATCH] IPVS: Allow boot time change of hash size Catalin(ux) M. BOIE
2008-11-26 14:40 ` Joseph Mack NA3T
2008-11-26 23:27   ` David Miller
2008-11-27  7:05     ` Catalin(ux) M. BOIE
2008-11-27  7:37       ` David Miller [this message]
2008-11-27  6:58   ` Catalin(ux) M. BOIE
2008-11-27 15:58     ` Joseph Mack NA3T
2008-11-28  8:49       ` Catalin(ux) M. BOIE
2008-11-28 14:55         ` Joseph Mack NA3T
2008-12-02 15:34           ` Catalin(ux) M. BOIE
2008-12-02 22:51             ` David Miller
2008-12-02 23:16               ` Catalin(ux) M. BOIE
2008-12-03  0:37                 ` David Miller
2009-12-28 18:49                   ` Mark Bergsma
2009-12-29  1:34                     ` Simon Horman
2010-01-04 13:57                       ` Patrick McHardy
2010-01-04 23:24                         ` Simon Horman
2010-01-05 11:02                           ` Mark Bergsma
2010-01-06 15:25                             ` Catalin(ux) M. BOIE
2010-01-05  0:20                     ` Simon Horman
2010-01-05  4:56                       ` Patrick McHardy
2008-12-03 21:11                 ` Graeme Fowler
2008-12-04  7:47                   ` Catalin(ux) M. BOIE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081126.233758.235891402.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=catab@embedromix.ro \
    --cc=jmack@wm7d.net \
    --cc=lvs-devel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).