netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dada1@cosmosbay.com
Cc: mingo@elte.hu, rjw@sisk.pl, linux-kernel@vger.kernel.org,
	kernel-testers@vger.kernel.org, efault@gmx.de,
	a.p.zijlstra@chello.nl, netdev@vger.kernel.org,
	cl@linux-foundation.org, hch@infradead.org
Subject: Re: [PATCH 2/6] fs: Introduce special dentries for pipes, socket, anon fd
Date: Thu, 27 Nov 2008 00:20:15 -0800 (PST)	[thread overview]
Message-ID: <20081127.002015.221466656.davem@davemloft.net> (raw)
In-Reply-To: <492DDC5C.1050602@cosmosbay.com>

From: Eric Dumazet <dada1@cosmosbay.com>
Date: Thu, 27 Nov 2008 00:31:40 +0100

> Sockets, pipes and anonymous fds have interesting properties.
 ...
> This patch defines a new DCACHE_SPECIAL flag, to mark a dentry as
> a special one (for sockets, pipes, anonymous fd), and a new
> d_alloc_special(const struct qstr *name, struct inode *inode)
> method, called by the three subsystems.
> 
> Internally, dput() can take a fast path to dput_special() for
> special dentries, avoiding an expensive atomic_dec_and_lock()
> 
> Differences betwen a special dentry and a normal one are :
> 
> 1) Special dentry has the DCACHE_SPECIAL flag
> 2) Special dentry's parent are themselves.
>    This to avoid taking a reference on 'root' dentry, shared
>    by too many dentries.
> 3) They are not hashed into global hash table
> 4) Their d_alias list is empty
> 
> (socket8 bench result : from 27.5s to 24s)
> 
> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>

Networking bits look fine:

Acked-by: David S. Miller <davem@davemloft.net>

  reply	other threads:[~2008-11-27  8:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-26 23:31 [PATCH 2/6] fs: Introduce special dentries for pipes, socket, anon fd Eric Dumazet
2008-11-27  8:20 ` David Miller [this message]
2008-11-27 10:04 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081127.002015.221466656.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=a.p.zijlstra@chello.nl \
    --cc=cl@linux-foundation.org \
    --cc=dada1@cosmosbay.com \
    --cc=efault@gmx.de \
    --cc=hch@infradead.org \
    --cc=kernel-testers@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=netdev@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).