From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [NET-NEXT PATCH 5/5] e100: cleanup link up/down messages
Date: Wed, 26 Nov 2008 16:03:02 -0800 [thread overview]
Message-ID: <20081127000302.22431.22196.stgit@gitlost.lost> (raw)
In-Reply-To: <20081127000206.22431.53339.stgit@gitlost.lost>
The system log messages created on a link status change need to follow a
specific format to work with tools some customers use. This also makes
the messages consistant with other Intel driver link messages.
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/e100.c | 10 ++++++----
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/net/e100.c b/drivers/net/e100.c
index 2001a63..dce7ff2 100644
--- a/drivers/net/e100.c
+++ b/drivers/net/e100.c
@@ -1580,11 +1580,13 @@ static void e100_watchdog(unsigned long data)
mii_ethtool_gset(&nic->mii, &cmd);
if(mii_link_ok(&nic->mii) && !netif_carrier_ok(nic->netdev)) {
- DPRINTK(LINK, INFO, "link up, %sMbps, %s-duplex\n",
- cmd.speed == SPEED_100 ? "100" : "10",
- cmd.duplex == DUPLEX_FULL ? "full" : "half");
+ printk(KERN_INFO "e100: %s NIC Link is Up %s Mbps %s Duplex\n",
+ nic->netdev->name,
+ cmd.speed == SPEED_100 ? "100" : "10",
+ cmd.duplex == DUPLEX_FULL ? "Full" : "Half");
} else if(!mii_link_ok(&nic->mii) && netif_carrier_ok(nic->netdev)) {
- DPRINTK(LINK, INFO, "link down\n");
+ printk(KERN_INFO "e100: %s NIC Link is Down\n",
+ nic->netdev->name);
}
mii_check_link(&nic->mii);
next prev parent reply other threads:[~2008-11-27 0:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 0:02 [NET-NEXT PATCH 1/5] igb: link up/down messages must follow a specific format Jeff Kirsher
2008-11-27 0:02 ` [NET-NEXT PATCH 2/5] ixgbe: cleanup link up/down messages Jeff Kirsher
2008-11-27 8:22 ` David Miller
2008-11-27 0:02 ` [NET-NEXT PATCH 3/5] e1000: " Jeff Kirsher
2008-11-27 8:22 ` David Miller
2008-11-27 0:02 ` [NET-NEXT PATCH 4/5] ixgb: " Jeff Kirsher
2008-11-27 8:23 ` David Miller
2008-11-27 0:03 ` Jeff Kirsher [this message]
2008-11-27 8:23 ` [NET-NEXT PATCH 5/5] e100: " David Miller
2008-11-27 8:21 ` [NET-NEXT PATCH 1/5] igb: link up/down messages must follow a specific format David Miller
2008-11-27 10:50 ` Andi Kleen
2008-11-27 11:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081127000302.22431.22196.stgit@gitlost.lost \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).