From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Dobriyan Subject: net-next: lockdep complains re percpu counters Date: Sun, 30 Nov 2008 16:07:26 +0300 Message-ID: <20081130130726.GA4365@x200.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: netdev@vger.kernel.org Return-path: Received: from ey-out-2122.google.com ([74.125.78.26]:62540 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751300AbYK3NDW (ORCPT ); Sun, 30 Nov 2008 08:03:22 -0500 Received: by ey-out-2122.google.com with SMTP id 6so867204eyi.37 for ; Sun, 30 Nov 2008 05:03:21 -0800 (PST) Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: This is net-next as of c5419e6f054c877339f754e02c3b1dafd88cd96c aka "cxgb3: Fix sparse warning and micro-optimize is_pure_response()". ================================= [ INFO: inconsistent lock state ] 2.6.28-rc6-netns #2 --------------------------------- inconsistent {softirq-on-W} -> {in-softirq-W} usage. recvfrom01/7632 [HC0[0]:SC1[1]:HE1:SE0] takes: (&fbc->lock){-+..}, at: [] __percpu_counter_add+0x63/0xc0 {softirq-on-W} state was registered at: [] __lock_acquire+0x4b9/0x9c0 [] lock_acquire+0x56/0x80 [] _spin_lock+0x36/0x50 [] __percpu_counter_add+0x63/0xc0 [] get_empty_filp+0x59/0x110 [] path_lookup_open+0x30/0xc0 [] do_filp_open+0xae/0x8a0 [] do_sys_open+0x76/0xd0 [] sys_open+0x1b/0x20 [] system_call_fastpath+0x16/0x1b [] 0xffffffffffffffff irq event stamp: 5698 hardirqs last enabled at (5698): [] debug_check_no_locks_freed+0xa1/0x150 hardirqs last disabled at (5697): [] debug_check_no_locks_freed+0x40/0x150 softirqs last enabled at (5656): [] release_sock+0xc1/0xf0 softirqs last disabled at (5657): [] call_softirq+0x1c/0x30 other info that might help us debug this: 2 locks held by recvfrom01/7632: #0: (slock-AF_INET/1){-+..}, at: [] tcp_v4_rcv+0x50b/0x840 #1: (slock-AF_INET){-+..}, at: [] sk_clone+0xe1/0x340 stack backtrace: Pid: 7632, comm: recvfrom01 Not tainted 2.6.28-rc6-netns #2 Call Trace: [] print_usage_bug+0x18d/0x1e0 [] mark_lock+0x887/0xb70 [] __lock_acquire+0x442/0x9c0 [] lock_acquire+0x56/0x80 [] ? __percpu_counter_add+0x63/0xc0 [] _spin_lock+0x36/0x50 [] ? __percpu_counter_add+0x63/0xc0 [] __percpu_counter_add+0x63/0xc0 [] sk_clone+0x307/0x340 [] inet_csk_clone+0x11/0xa0 [] tcp_create_openreq_child+0x24/0x470 [] tcp_v4_syn_recv_sock+0x53/0x210 [] tcp_check_req+0x125/0x450 [] ? local_bh_enable+0xa4/0x110 [] tcp_v4_do_rcv+0x13d/0x230 [] tcp_v4_rcv+0x745/0x840 [] ip_local_deliver_finish+0x124/0x2b0 [] ip_local_deliver+0xa0/0xb0 [] ip_rcv_finish+0x10c/0x3c0 [] ip_rcv+0x1c0/0x300 [] netif_receive_skb+0x379/0x400 [] ? process_backlog+0x8b/0x100 [] process_backlog+0x97/0x100 [] net_rx_action+0x14a/0x210 [] __do_softirq+0x88/0x150 [] ? release_sock+0xc1/0xf0 [] call_softirq+0x1c/0x30 [] do_softirq+0x77/0xd0 [] ? release_sock+0xc1/0xf0 [] local_bh_enable_ip+0xeb/0x110 [] _spin_unlock_bh+0x39/0x40 [] ? release_sock+0x8e/0xf0 [] release_sock+0xc1/0xf0 [] inet_stream_connect+0x198/0x2e0 [] ? autoremove_wake_function+0x0/0x40 [] ? autoremove_wake_function+0x0/0x40 [] sys_connect+0x7d/0xc0 [] ? sysret_check+0x27/0x62 [] ? trace_hardirqs_on_caller+0xba/0x130 [] ? trace_hardirqs_on_thunk+0x3a/0x3f [] system_call_fastpath+0x16/0x1b