From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org,
jeff@garzik.org, peter.p.waskiewicz.jr@intel.com,
linux-pci@vger.kernel.org
Subject: Re: [NET-NEXT PATCH] ixgbe: Implement PCIe AER support
Date: Mon, 01 Dec 2008 23:25:27 -0800 (PST) [thread overview]
Message-ID: <20081201.232527.66213356.davem@davemloft.net> (raw)
In-Reply-To: <20081201174754.2e5ef401@extreme>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 1 Dec 2008 17:47:54 -0800
> pci_enable_pcie_error_reporting should be checking for pci_read/pci_write
> config errors and does not.
>
> Your driver should be checking for pci_enable_pcie_error_reporting failing.
Agreed.
next prev parent reply other threads:[~2008-12-02 7:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 0:41 [NET-NEXT PATCH] ixgbe: Implement PCIe AER support Jeff Kirsher
2008-12-02 1:47 ` Stephen Hemminger
2008-12-02 7:25 ` David Miller [this message]
2008-12-02 17:23 ` [PATCH] pciaer: report config read/write errors Stephen Hemminger
2008-12-02 18:41 ` Waskiewicz Jr, Peter P
2008-12-02 19:04 ` Loic Prylli
2008-12-02 19:44 ` Stephen Hemminger
2008-12-02 20:14 ` Loic Prylli
2008-12-02 21:41 ` Stephen Hemminger
2008-12-09 7:13 ` [NET-NEXT PATCH] ixgbe: Implement PCIe AER support Waskiewicz Jr, Peter P
2008-12-02 8:19 ` Waskiewicz Jr, Peter P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081201.232527.66213356.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).