From: David Miller <davem@davemloft.net>
To: dada1@cosmosbay.com
Cc: adobriyan@gmail.com, netdev@vger.kernel.org
Subject: Re: net-next: lockdep complains re percpu counters
Date: Mon, 01 Dec 2008 23:37:48 -0800 (PST) [thread overview]
Message-ID: <20081201.233748.204870635.davem@davemloft.net> (raw)
In-Reply-To: <4932C128.6040401@cosmosbay.com>
From: Eric Dumazet <dada1@cosmosbay.com>
Date: Sun, 30 Nov 2008 17:36:56 +0100
> [PATCH] net: percpu_counter_inc() should not be called in BH-disabled section
>
> I checked all per_cpu_counter_xxx() usages in network tree, and I think
> all call sites are BH enabled except one in inet_csk_listen_stop().
>
> commit dd24c00191d5e4a1ae896aafe33c6b8095ab4bd1
> (net: Use a percpu_counter for orphan_count)
> replaced atomic_t orphan_count to a percpu_counter.
>
> atomic_inc()/atomic_dec() can be called from any context, while percpu_counter_xxx()
> should be called from a consistent state.
>
> For orphan_count, this context can be the BH-enabled one.
>
> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
I applied this preemptively even though Alexey hasn't given
test feedback yet, and I also added a mention of his report
in the commit message.
Thanks.
next prev parent reply other threads:[~2008-12-02 7:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-30 13:07 net-next: lockdep complains re percpu counters Alexey Dobriyan
2008-11-30 16:36 ` Eric Dumazet
2008-12-02 7:37 ` David Miller [this message]
2008-12-02 8:29 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081201.233748.204870635.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@gmail.com \
--cc=dada1@cosmosbay.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).