From: Inaky Perez-Gonzalez <inaky@linux.intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 08/39] wimax: Mappping of generic netlink family IDs to net devices
Date: Tue, 2 Dec 2008 18:06:39 -0800 [thread overview]
Message-ID: <200812021806.39847.inaky@linux.intel.com> (raw)
In-Reply-To: <1227779241.3809.36.camel@johannes.berg>
On Thursday 27 November 2008, Johannes Berg wrote:
> On Wed, 2008-11-26 at 15:07 -0800, Inaky Perez-Gonzalez wrote:
> > + }
> > + }
> > + d_printf(1, NULL, "wimax: no device associated to ID %d\n", id);
>
> remove debug statement (or make it depend on !wimax_dev)
>
> > + wimax_dev = NULL;
> > +out_unlock:
> > + spin_unlock(&wimax_id_table_lock);
> > + d_fnend(3, NULL, "(info %p) = %p\n", info, wimax_dev);
> > + return wimax_dev;
>
> No need for gotos any more :)
Duh ... sometimes the autopilot is not a good thing.
Fixed, thanks
--
Inaky
next prev parent reply other threads:[~2008-12-03 2:11 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-26 22:40 [PATCH 00/39] merge request for WiMAX kernel stack and i2400m driver v2 Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 01/39] wimax: documentation for the stack Inaky Perez-Gonzalez
2008-11-27 9:29 ` Johannes Berg
2008-12-03 2:07 ` Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 02/39] wimax: declarations for the in-kernel WiMAX API Inaky Perez-Gonzalez
2008-11-27 9:32 ` Johannes Berg
2008-12-03 2:07 ` Inaky Perez-Gonzalez
2008-12-04 9:04 ` Johannes Berg
2008-12-04 20:11 ` Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 03/39] wimax: constants and definitions to interact with user space Inaky Perez-Gonzalez
2008-11-27 9:41 ` Johannes Berg
2008-12-03 2:06 ` Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 04/39] wimax: internal API for the kernel space WiMAX stack Inaky Perez-Gonzalez
2008-11-27 9:43 ` Johannes Berg
2008-12-03 2:07 ` Inaky Perez-Gonzalez
2008-12-04 9:02 ` Johannes Berg
2008-12-04 19:22 ` Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 05/39] wimax: debug macros and debug settings for the " Inaky Perez-Gonzalez
2008-11-27 9:28 ` Johannes Berg
2008-12-03 2:07 ` Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 06/39] genetlink: export genl_unregister_mc_group() Inaky Perez-Gonzalez
2008-11-26 23:07 ` Johannes Berg
2008-11-26 22:40 ` [PATCH 07/39] wimax: generic WiMAX device management (registration, deregistration, etc) Inaky Perez-Gonzalez
2008-11-27 10:40 ` Patrick McHardy
2008-12-03 2:06 ` Inaky Perez-Gonzalez
2008-12-04 13:02 ` Patrick McHardy
2008-11-26 22:40 ` [PATCH 08/39] wimax: Mappping of generic netlink family IDs to net devices Inaky Perez-Gonzalez
2008-11-27 9:47 ` Johannes Berg
2008-12-03 2:06 ` Inaky Perez-Gonzalez [this message]
2008-11-26 22:40 ` [PATCH 09/39] wimax: provides user space with information needed when opening a WiMAX device Inaky Perez-Gonzalez
2008-11-27 9:53 ` Johannes Berg
2008-11-27 12:20 ` Johannes Berg
2008-12-03 2:06 ` Inaky Perez-Gonzalez
2008-11-27 10:44 ` Patrick McHardy
2008-11-26 22:40 ` [PATCH 10/39] wimax: Generic messaging interface between user space and driver/device Inaky Perez-Gonzalez
2008-11-27 9:55 ` Johannes Berg
2008-11-27 12:35 ` Thomas Graf
2008-12-03 2:02 ` Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 11/39] wimax: RF-kill framework integration Inaky Perez-Gonzalez
2008-11-27 9:56 ` Johannes Berg
2008-12-03 2:03 ` Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 12/39] wimax: API call to reset a WiMAX device Inaky Perez-Gonzalez
2008-11-27 9:58 ` Johannes Berg
2008-12-03 2:05 ` Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 13/39] wimax: Makefile, Kconfig and docbook linkage for the stack Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 14/39] i2400m: documentation and instructions for usage Inaky Perez-Gonzalez
2008-11-27 10:01 ` Johannes Berg
2008-12-03 2:06 ` Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 15/39] i2400m: host-to-device protocol definitions Inaky Perez-Gonzalez
2008-11-27 10:04 ` Johannes Berg
2008-12-03 2:06 ` Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 16/39] i2400m: core driver definitions and API Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 17/39] i2400m: Generic probe/disconnect, reset and message passing Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 18/39] i2400m: linkage to the networking stack Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 19/39] i2400m: sysfs controls Inaky Perez-Gonzalez
2008-11-27 9:23 ` Johannes Berg
2008-11-26 22:40 ` [PATCH 20/39] i2400m: rfkill integration with the WiMAX stack Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 21/39] i2400m: firmware loading and bootrom initialization Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 22/39] i2400m: handling of the data/control reception path Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 23/39] i2400m: handling of the data/control transmission path Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 24/39] i2400m: various functions for device management Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 25/39] i2400m/USB: header for the USB bus driver Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 26/39] i2400m/USB: error density tracking Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 27/39] i2400m/USB: main probe/disconnect and backend routines Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 28/39] i2400m/USB: firmware upload backend Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 29/39] i2400m/USB: handling of notifications from the device Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 30/39] i2400m/USB: read transactions from the USB device Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 31/39] i2400m/USB: write transactions to " Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 32/39] i2400m/SDIO: header for the SDIO subdriver Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 33/39] i2400m/SDIO: main probe/disconnect and backend routines Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 34/39] i2400m/SDIO: firmware upload backend Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 35/39] i2400m/SDIO: read transactions from the SDIO device Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 36/39] i2400m/SDIO: write transactions to " Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 37/39] i2400m: Makefile and Kconfig Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 38/39] wimax: export linux/wimax.h and linux/wimax/i2400m.h with headers_install Inaky Perez-Gonzalez
2008-11-26 22:40 ` [PATCH 39/39] wimax/i2400m: add CREDITS and MAINTAINERS entries Inaky Perez-Gonzalez
2008-11-27 8:17 ` [PATCH 00/39] merge request for WiMAX kernel stack and i2400m driver v2 David Miller
2008-11-27 9:24 ` Inaky Perez-Gonzalez
2008-11-27 10:18 ` Arkadiusz Miskiewicz
2008-11-27 10:41 ` Marcel Holtmann
2008-11-27 10:54 ` Johannes Berg
2008-11-27 11:14 ` Marcel Holtmann
2008-11-27 11:23 ` Johannes Berg
2008-11-30 4:05 ` Dan Williams
2008-11-27 11:47 ` Andi Kleen
2008-11-27 11:50 ` Johannes Berg
2008-11-27 16:51 ` Inaky Perez-Gonzalez
2008-12-03 2:07 ` Inaky Perez-Gonzalez
2008-12-03 23:03 ` Dan Williams
2008-12-04 9:00 ` Johannes Berg
2008-12-04 19:21 ` Inaky Perez-Gonzalez
2008-12-04 23:09 ` Johannes Berg
2008-12-03 2:10 ` Inaky Perez-Gonzalez
2008-12-04 9:01 ` Johannes Berg
2008-12-04 13:37 ` Marcel Holtmann
-- strict thread matches above, loose matches on Subject: below --
2008-11-26 7:38 Inaky Perez-Gonzalez
2008-11-26 7:39 ` [PATCH 08/39] wimax: Mappping of generic netlink family IDs to net devices Inaky Perez-Gonzalez
2008-11-24 21:50 [PATCH 00/39] merge request for WiMAX kernel stack and i2400m driver Inaky Perez-Gonzalez
2008-11-24 21:50 ` [PATCH 08/39] wimax: Mappping of generic netlink family IDs to net devices Inaky Perez-Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812021806.39847.inaky@linux.intel.com \
--to=inaky@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).