From: David Miller <davem@davemloft.net>
To: kkeil@suse.de
Cc: akpm@linux-foundation.org, netdev@vger.kernel.org,
linux-kernel@lebenslange-mailadresse.de, calle@calle.de,
stable@kernel.org
Subject: Re: [patch for 2.6.28? 1/1] b1isa: fix b1isa_exit() to really remove registered capi controllers
Date: Wed, 03 Dec 2008 20:57:45 -0800 (PST) [thread overview]
Message-ID: <20081203.205745.127195542.davem@davemloft.net> (raw)
In-Reply-To: <20081202114926.GA21919@pingi.kke.suse.de>
From: Karsten Keil <kkeil@suse.de>
Date: Tue, 2 Dec 2008 12:49:26 +0100
> On "/etc/init.d/capiutils stop", this oops happened.
>
> The oops happens on reading /proc/capi/controllers because
> capi_ctrl->procinfo is called for the wrongly not unregistered
> controller, which points to b1isa_procinfo(), which was removed on
> module unload.
>
> b1isa_exit() did not call b1isa_remove() for its controllers because
> io[0] == 0 on module unload despite having been 0x340 on module load.
>
> Besides, just removing the controllers that where added on module
> load time and not those that were added later via b1isa_add_card() is
> wrong too - the place where all added cards are found is isa_dev[].
...
> Signed-off-by: Wilfried Klaebe <linux-kernel@lebenslange-mailadresse.de>
> Cc: <calle@calle.de>
> Cc: <stable@kernel.org> [2.6.everything]
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Acked-by: Karsten Keil <kkeil@suse.de>
Patch applied, thanks.
next prev parent reply other threads:[~2008-12-04 4:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 11:49 [patch for 2.6.28? 1/1] b1isa: fix b1isa_exit() to really remove registered capi controllers Karsten Keil
2008-12-04 4:57 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-12-01 22:01 akpm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081203.205745.127195542.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=calle@calle.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@lebenslange-mailadresse.de \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).