From: Baruch Siach <baruch@tkos.co.il>
To: David Brownell <david-b@pacbell.net>
Cc: spi-devel-general@lists.sourceforge.net,
Claudio Lanconelli <lanconelli.claudio@eptar.com>,
Shachar Shemesh <shachar@lingnu.com>,
Network development list <netdev@vger.kernel.org>
Subject: Re: [spi-devel-general] [PATCH] enc28j60: Fix sporadic packet loss (correction)
Date: Wed, 3 Dec 2008 08:22:13 +0200 [thread overview]
Message-ID: <20081203062213.GB3361@tarshish> (raw)
In-Reply-To: <200812021444.03225.david-b@pacbell.net>
HI David,
On Tue, Dec 02, 2008 at 02:44:02PM -0800, David Brownell wrote:
> On Tuesday 02 December 2008, Baruch Siach wrote:
> > Our on-chip SPI master is the Synopsys DesignWare one. I wrote a driver
> > for this SPI master. This driver is somewhat usable, but not complete yet.
> > I'm now in the process of adding DMA support to the driver (PL080) to
> > overcome some nasty design peculiarities of this SPI master.
> >
> > Peter Pearse has poster a (incomplete) patch set with a driver for the PL080
> > DMA controller to the LAKL last week, but I see no push for integrating it
> > into the mainline. So I doubt there's any great value in this SPI master
> > driver as of now.
>
> I certainly wouldn't expect that on the ARM list. It's
> not exactly the responsibility of that list to address
> anything other than arch/arm/* goodies.
Apparently I haven't explained myself clear enough. The (partial) driver that
Peter Pearse has posted[1] to LAKL is for the PL080 DMA controller. This
driver is ARM specific, so LAKL seems to be reasonable place even though the
driver itself is under drivers/amba (which is ARM specific as well).
My Synopsys DesignWare SPI master driver will, when complete, depend on this
DMA controller driver, that's not in the mainline (yet).
> Post it to the SPI list instead. If it's useful to you,
> it could well be useful to others... I'd have no problems
> merging such a driver, if it's reasonably clean/correct
> and is known to work well enough to support enc28j60.
I hope I'll have time to clean up the SPI master driver code in its current
form, and post in a few days.
baruch
[1]
http://lists.arm.linux.org.uk/lurker/message/20081121.134729.8fe35d0d.en.html
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2008-12-03 6:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081202085947.GB24490@diamond.tkos.co.il>
2008-12-02 21:05 ` [spi-devel-general] [PATCH] enc28j60: Fix sporadic packet loss (correction) David Brownell
2008-12-02 21:35 ` Baruch Siach
2008-12-02 22:44 ` David Brownell
2008-12-03 6:22 ` Baruch Siach [this message]
2008-12-03 7:04 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081203062213.GB3361@tarshish \
--to=baruch@tkos.co.il \
--cc=david-b@pacbell.net \
--cc=lanconelli.claudio@eptar.com \
--cc=netdev@vger.kernel.org \
--cc=shachar@lingnu.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).