netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: D.Barow-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org
Subject: Re: [PATCH 3/3] hso modem port detection fix patch
Date: Mon, 08 Dec 2008 02:54:47 -0800 (PST)	[thread overview]
Message-ID: <20081208.025447.99306942.davem@davemloft.net> (raw)
In-Reply-To: <493CFAA9.6080401-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>

From: Denis Joseph Barrow <D.Barow-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
Date: Mon, 08 Dec 2008 11:44:57 +0100

Again, please CC: Alan for changes that might even remotely
be TTY layer related and thus he'd be interested in reviewing.

Thanks.

> This patch will clash with the previously posted.
> [PATCH 1/3] hso modem signals patch fix & should only
> be applied if the hso modem signals patch fix patch
> is not applied.
> 
> Fixed incorrect check for the modem port,
> Signed-off-by: Denis Joseph Barrow <D.Barow-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
> ---
> Index: netdev-2.6/drivers/net/usb/hso.c
> ===================================================================
> --- netdev-2.6.orig/drivers/net/usb/hso.c	2008-12-08 11:29:03.000000000 +0100
> +++ netdev-2.6/drivers/net/usb/hso.c	2008-12-08 11:30:00.000000000 +0100
> @@ -2343,7 +2343,7 @@
>  	serial->parent = hso_dev;
>  	hso_dev->port_data.dev_serial = serial;
>  
> -	if (port & HSO_PORT_MODEM)
> +	if ((port & HSO_PORT_MASK) == HSO_PORT_MODEM)
>  		num_urbs = 2;
>  	else
>  		num_urbs = 1;
> 
> 
> 
> -- 
> best regards,
> D.J. Barrow
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2008-12-08 10:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-08 10:44 [PATCH 3/3] hso modem port detection fix patch Denis Joseph Barrow
     [not found] ` <493CFAA9.6080401-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
2008-12-08 10:54   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081208.025447.99306942.davem@davemloft.net \
    --to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
    --cc=D.Barow-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org \
    --cc=alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).