* [PATCH 3/3] hso modem port detection fix patch
@ 2008-12-08 10:44 Denis Joseph Barrow
[not found] ` <493CFAA9.6080401-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Denis Joseph Barrow @ 2008-12-08 10:44 UTC (permalink / raw)
To: Linux USB kernel mailing list, Linux netdev Mailing list
[-- Attachment #1: Type: text/plain, Size: 779 bytes --]
This patch will clash with the previously posted.
[PATCH 1/3] hso modem signals patch fix & should only
be applied if the hso modem signals patch fix patch
is not applied.
Fixed incorrect check for the modem port,
Signed-off-by: Denis Joseph Barrow <D.Barow@option.com>
---
Index: netdev-2.6/drivers/net/usb/hso.c
===================================================================
--- netdev-2.6.orig/drivers/net/usb/hso.c 2008-12-08 11:29:03.000000000 +0100
+++ netdev-2.6/drivers/net/usb/hso.c 2008-12-08 11:30:00.000000000 +0100
@@ -2343,7 +2343,7 @@
serial->parent = hso_dev;
hso_dev->port_data.dev_serial = serial;
- if (port & HSO_PORT_MODEM)
+ if ((port & HSO_PORT_MASK) == HSO_PORT_MODEM)
num_urbs = 2;
else
num_urbs = 1;
--
best regards,
D.J. Barrow
[-- Attachment #2: hso_modem_port_fix.patch --]
[-- Type: text/x-diff, Size: 573 bytes --]
Fixed incorrect check for the modem port,
Signed-off-by: Denis Joseph Barrow <D.Barow@option.com>
---
Index: netdev-2.6/drivers/net/usb/hso.c
===================================================================
--- netdev-2.6.orig/drivers/net/usb/hso.c 2008-12-08 11:29:03.000000000 +0100
+++ netdev-2.6/drivers/net/usb/hso.c 2008-12-08 11:30:00.000000000 +0100
@@ -2343,7 +2343,7 @@
serial->parent = hso_dev;
hso_dev->port_data.dev_serial = serial;
- if (port & HSO_PORT_MODEM)
+ if ((port & HSO_PORT_MASK) == HSO_PORT_MODEM)
num_urbs = 2;
else
num_urbs = 1;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 3/3] hso modem port detection fix patch
[not found] ` <493CFAA9.6080401-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
@ 2008-12-08 10:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-12-08 10:54 UTC (permalink / raw)
To: D.Barow-x9gZzRpC1QbQT0dZR+AlfA
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA,
alan-qBU/x9rampVanCEyBjwyrvXRex20P6io
From: Denis Joseph Barrow <D.Barow-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
Date: Mon, 08 Dec 2008 11:44:57 +0100
Again, please CC: Alan for changes that might even remotely
be TTY layer related and thus he'd be interested in reviewing.
Thanks.
> This patch will clash with the previously posted.
> [PATCH 1/3] hso modem signals patch fix & should only
> be applied if the hso modem signals patch fix patch
> is not applied.
>
> Fixed incorrect check for the modem port,
> Signed-off-by: Denis Joseph Barrow <D.Barow-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
> ---
> Index: netdev-2.6/drivers/net/usb/hso.c
> ===================================================================
> --- netdev-2.6.orig/drivers/net/usb/hso.c 2008-12-08 11:29:03.000000000 +0100
> +++ netdev-2.6/drivers/net/usb/hso.c 2008-12-08 11:30:00.000000000 +0100
> @@ -2343,7 +2343,7 @@
> serial->parent = hso_dev;
> hso_dev->port_data.dev_serial = serial;
>
> - if (port & HSO_PORT_MODEM)
> + if ((port & HSO_PORT_MASK) == HSO_PORT_MODEM)
> num_urbs = 2;
> else
> num_urbs = 1;
>
>
>
> --
> best regards,
> D.J. Barrow
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-08 10:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-08 10:44 [PATCH 3/3] hso modem port detection fix patch Denis Joseph Barrow
[not found] ` <493CFAA9.6080401-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
2008-12-08 10:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).