From: Alexey Dobriyan <adobriyan@gmail.com>
To: Jianjun Kong <jianjun@zeuux.org>
Cc: "David S. Miller" <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: cleanup for net/core/dev.c
Date: Mon, 8 Dec 2008 18:32:18 +0300 [thread overview]
Message-ID: <20081208153218.GA3788@x200.localdomain> (raw)
In-Reply-To: <20081208145214.GA6830@ubuntu>
On Mon, Dec 08, 2008 at 10:52:14PM +0800, Jianjun Kong wrote:
> - if (sizeof_priv) {
> - dev->priv = ((char *)dev +
> - ((sizeof(struct net_device) + NETDEV_ALIGN_CONST)
> - & ~NETDEV_ALIGN_CONST));
> - }
> + if (sizeof_priv)
> + dev->priv = netdev_priv(dev);
If I understood all of this correctly, ->priv is going away, so there is
no point in changing it's initialisation.
prev parent reply other threads:[~2008-12-08 15:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 14:52 [PATCH] net: cleanup for net/core/dev.c Jianjun Kong
2008-12-08 15:32 ` Alexey Dobriyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081208153218.GA3788@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=jianjun@zeuux.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox