From: Thomas Renninger <trenn@suse.de>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jbarnes@virtuousgeek.org" <jbarnes@virtuousgeek.org>,
Rafael Wysocki <rwysocki@suse.de>,
"shemminger@linux-foundation.org"
<shemminger@linux-foundation.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Stable@kernel.org" <Stable@kernel.org>
Subject: Re: [PATCH] PCIe ASPM causes machine (HP Compaq 6735s) to sometimes freeze hard at boot at PCI initialization time
Date: Mon, 8 Dec 2008 15:56:57 +0100 [thread overview]
Message-ID: <200812081556.59070.trenn@suse.de> (raw)
In-Reply-To: <1228699962.13024.2.camel@sli10-desk.sh.intel.com>
On Monday 08 December 2008 02:32:42 Shaohua Li wrote:
> On Sat, 2008-12-06 at 02:21 +0800, Matthew Garrett wrote:
> > On Fri, Dec 05, 2008 at 02:07:13PM +0100, Thomas Renninger wrote:
> > > PCIE: Break out of endless loop waiting for PCI config bits to switch
> > >
> > > Makes a Compaq 6735s boot reliably again which hang in the loop
> > > on some boots.
> >
> > Which device does it get stuck on?
> >
> > > + if (loop_count == 100)
> > > + dev_printk (KERN_WARNING, &pdev->dev, "Could not configure ASPM\n");
> >
> > "ASPM: Could not configure common clock\n"? ASPM should still work,
> > though with higher latency. It probably also needs to revert the
> > configuration changes.
>
> Yep, Just undo the pci config writes of pcie_aspm_configure_common_clock
> should be fine to me. Maybe an expiration time is ok here.
> Does the device work after this?
After not writing back the pci values as done with this patch?
Yes, I think it did.
It definitely does with this patch.
What about this one:
next prev parent reply other threads:[~2008-12-08 14:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-28 12:28 PCIe ASPM causes machine (HP Compaq 6735s) to sometimes freeze hard at boot at PCI initialization time Thomas Renninger
2008-12-05 12:41 ` Identified: PCIe ASPM causes machine (HP Compaq 6735s) to sometimes hang in endless loop Thomas Renninger
2008-12-05 13:07 ` [PATCH] PCIe ASPM causes machine (HP Compaq 6735s) to sometimes freeze hard at boot at PCI initialization time Thomas Renninger
2008-12-05 18:21 ` Matthew Garrett
2008-12-08 1:32 ` Shaohua Li
2008-12-08 14:56 ` Thomas Renninger [this message]
2008-12-08 15:04 ` Thomas Renninger
2008-12-08 15:09 ` Matthew Garrett
2008-12-08 15:17 ` Thomas Renninger
2008-12-09 1:19 ` Shaohua Li
2008-12-09 12:05 ` Thomas Renninger
2008-12-09 23:05 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812081556.59070.trenn@suse.de \
--to=trenn@suse.de \
--cc=Stable@kernel.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=netdev@vger.kernel.org \
--cc=rwysocki@suse.de \
--cc=shaohua.li@intel.com \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).