From: David Miller <davem@davemloft.net>
To: bazsi@balabit.hu
Cc: netdev@vger.kernel.org, tproxy@lists.balabit.hu,
hidden@sch.bme.hu, panther@balabit.hu
Subject: Re: [RFC][PATCH] [TPROXY] kick out TIME_WAIT sockets in case a new connection comes in with the same tuple
Date: Tue, 09 Dec 2008 22:18:38 -0800 (PST) [thread overview]
Message-ID: <20081209.221838.206534714.davem@davemloft.net> (raw)
In-Reply-To: <1228812695.7631.16.camel@bzorp.balabit>
From: Balazs Scheidler <bazsi@balabit.hu>
Date: Tue, 09 Dec 2008 08:51:35 +0000
> Hi,
>
> I'd like to get some guidance regarding the following patch. There's a
> severe performance limitation related to TIME_WAIT sockets and TProxy rules.
> The patch below is the 'nice' approach, but it adds 6 bytes to
> inet_sock and inet_timewait_sock. The 'ugly' approach would be to schedule the
> removal of the affected TIME_WAIT sockets at PREROUTING time.
>
> This post is meant to get some review, but please do not apply this patch this time.
I have no general objection to this, but people seem to be
experts at making various parts of the TCP socket structures
larger and larger :-(
next prev parent reply other threads:[~2008-12-10 6:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-09 8:51 [RFC][PATCH] [TPROXY] kick out TIME_WAIT sockets in case a new connection comes in with the same tuple Balazs Scheidler
2008-12-10 6:18 ` David Miller [this message]
2008-12-10 8:52 ` Balazs Scheidler
2008-12-10 8:57 ` David Miller
2008-12-10 10:15 ` Balazs Scheidler
2008-12-10 23:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081209.221838.206534714.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bazsi@balabit.hu \
--cc=hidden@sch.bme.hu \
--cc=netdev@vger.kernel.org \
--cc=panther@balabit.hu \
--cc=tproxy@lists.balabit.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).