From: David Miller <davem@davemloft.net>
To: sathyap@serverengines.com
Cc: netdev@vger.kernel.org, jgarzik@pobox.com, jeff@garzik.org,
subbus@serverengines.com
Subject: Re: [PATCH 01/11] benet: header and init functions
Date: Tue, 09 Dec 2008 22:44:28 -0800 (PST) [thread overview]
Message-ID: <20081209.224428.261629001.davem@davemloft.net> (raw)
In-Reply-To: <1228832384.6435.94.camel@sperla-laptop>
From: Sathya Perla <sathyap@serverengines.com>
Date: Tue, 09 Dec 2008 19:49:44 +0530
> + pnob = netdev->priv;
netdev->priv should never be accessed directly, use
netdev_priv() always
netdev->priv has even been removed in the net-next-2.6
tree so we don't want any new references sneaking into
the tree as this will cause build failures.
> + struct be_net_object *pnob = (struct be_net_object *)netdev->priv;
...
> + struct be_net_object *pnob = (struct be_net_object *)netdev->priv;
And when you convert these cases, remove the casts.
They are pointless since netdev_priv() (and netdev->priv) are void
pointers.
next prev parent reply other threads:[~2008-12-10 6:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-09 14:19 [PATCH 01/11] benet: header and init functions Sathya Perla
2008-12-10 6:44 ` David Miller [this message]
2008-12-10 23:03 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081209.224428.261629001.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=sathyap@serverengines.com \
--cc=subbus@serverengines.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox