From: David Miller <davem@davemloft.net>
To: sathyap@serverengines.com
Cc: netdev@vger.kernel.org, jgarzik@pobox.com, subbus@serverengines.com
Subject: Re: [PATCH 08/11] benet: hardware host interface header files
Date: Tue, 09 Dec 2008 22:49:04 -0800 (PST) [thread overview]
Message-ID: <20081209.224904.181841905.davem@davemloft.net> (raw)
In-Reply-To: <1228832449.6435.101.camel@sperla-laptop>
From: Sathya Perla <sathyap@serverengines.com>
Date: Tue, 09 Dec 2008 19:50:49 +0530
> +} __packed;
Packed is pointless for datastructures containing only
8-bit integers.
> + u8 interrupt32; /* DWORD 0 */
> + u8 interrupt33; /* DWORD 0 */
> + u8 interrupt34; /* DWORD 0 */
> + u8 interrupt35; /* DWORD 0 */
> + u8 interrupt36; /* DWORD 0 */
> + u8 interrupt37; /* DWORD 0 */
> + u8 interrupt38; /* DWORD 0 */
> + u8 interrupt39; /* DWORD 0 */
> + u8 interrupt40; /* DWORD 0 */
> + u8 interrupt41; /* DWORD 0 */
> + u8 interrupt42; /* DWORD 0 */
> + u8 interrupt43; /* DWORD 0 */
Why do all of these comments say "DWORD 0"? It can't
mean that the member is at offset "DWORD 0", there
are too many of these bytes to stay in DWORD 0.
prev parent reply other threads:[~2008-12-10 6:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-09 14:20 [PATCH 08/11] benet: hardware host interface header files Sathya Perla
2008-12-10 6:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081209.224904.181841905.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=sathyap@serverengines.com \
--cc=subbus@serverengines.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox