From: David Miller <davem@davemloft.net>
To: adobriyan@gmail.com
Cc: a.beregalov@gmail.com, linux-next@vger.kernel.org,
netdev@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: [PATCH] simnet: convert to net_device_ops
Date: Tue, 09 Dec 2008 22:57:28 -0800 (PST) [thread overview]
Message-ID: <20081209.225728.07389385.davem@davemloft.net> (raw)
In-Reply-To: <20081209150827.GA8134@x200.localdomain>
From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Tue, 9 Dec 2008 18:08:27 +0300
> On Tue, Dec 09, 2008 at 05:11:17PM +0300, Alexander Beregalov wrote:
> > CC arch/ia64/hp/sim/simeth.o
> > arch/ia64/hp/sim/simeth.c: In function 'simeth_probe1':
> > arch/ia64/hp/sim/simeth.c:212: error: 'struct net_device' has no member named 'open'
>
> [PATCH] simeth: convert to net_device_ops
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
This doesn't explain the build failure.
Using ->open() and friends should work perfectly fine for drivers not
yet converted to netdev_ops. The code protected by COMPAT_NET_DEV_OPS
provides this, and we force that Kconfig option to always be on.
I don't want to add this patch and just shrug off this build failure.
If this build failures, we should be seeing 200 other drivers not
build too.
I suspect something is messed up with this person's kernel config
or similar.
next prev parent reply other threads:[~2008-12-10 6:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-09 14:11 next-20081209: build problem at arch/ia64/hp/sim/simeth.c Alexander Beregalov
2008-12-09 15:08 ` [PATCH] simnet: convert to net_device_ops Alexey Dobriyan
2008-12-10 6:57 ` David Miller [this message]
2008-12-10 11:21 ` Alexander Beregalov
2008-12-10 23:25 ` David Miller
2008-12-10 11:54 ` Alexey Dobriyan
2008-12-16 9:56 ` David Miller
2008-12-10 6:41 ` next-20081209: build problem at arch/ia64/hp/sim/simeth.c David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081209.225728.07389385.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=a.beregalov@gmail.com \
--cc=adobriyan@gmail.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).