From: David Miller <davem@davemloft.net>
To: steve.glendinning@smsc.com
Cc: netdev@vger.kernel.org, vlad.lyalikov@smsc.com, ian.saturley@smsc.com
Subject: Re: [PATCH] smsc9420: SMSC LAN9420 10/100 PCI ethernet adapter
Date: Tue, 09 Dec 2008 23:02:20 -0800 (PST) [thread overview]
Message-ID: <20081209.230220.94138000.davem@davemloft.net> (raw)
In-Reply-To: <1228834663-20907-1-git-send-email-steve.glendinning@smsc.com>
From: Steve Glendinning <steve.glendinning@smsc.com>
Date: Tue, 9 Dec 2008 14:57:43 +0000
> +uint debug_mode = (DBG_MCAST | DBG_WARNING | DBG_INIT | DBG_CLOSE | DBG_LINK |
> + DBG_PWR);
> +module_param(debug_mode, uint, 0);
> +MODULE_PARM_DESC(debug_mode, "enables debugging messages");
We have a standard way to do this, and standard bitmask values,
and an ethtool call to set this. Please use it.
Look at how niu_debug is used in drivers/net/niu.c, functions
like netif_msg_init(), and assosciated interfaces.
There really is no need for this home-grown stuff :-)
Otherwise this driver looks pretty good.
next prev parent reply other threads:[~2008-12-10 7:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-09 14:57 [PATCH] smsc9420: SMSC LAN9420 10/100 PCI ethernet adapter Steve Glendinning
2008-12-10 7:02 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-12-10 11:56 Steve Glendinning
2008-12-12 4:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081209.230220.94138000.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ian.saturley@smsc.com \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@smsc.com \
--cc=vlad.lyalikov@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).