* [PATCH 5/6] pkt_sched: sch_htb: Optimize htb_find_next_upper()
@ 2008-12-09 10:21 Jarek Poplawski
0 siblings, 0 replies; only message in thread
From: Jarek Poplawski @ 2008-12-09 10:21 UTC (permalink / raw)
To: David Miller; +Cc: Martin Devera, Patrick McHardy, netdev
htb_id_find_next_upper() is usually called to find a class with next
id after some previously removed class, so let's move a check for
equality to the end: it's the least likely here.
Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
---
net/sched/sch_htb.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c
index 2e0a74c..f44a4be 100644
--- a/net/sched/sch_htb.c
+++ b/net/sched/sch_htb.c
@@ -702,14 +702,14 @@ static struct rb_node *htb_id_find_next_upper(int prio, struct rb_node *n,
while (n) {
struct htb_class *cl =
rb_entry(n, struct htb_class, node[prio]);
- if (id == cl->common.classid)
- return n;
if (id > cl->common.classid) {
n = n->rb_right;
- } else {
+ } else if (id < cl->common.classid) {
r = n;
n = n->rb_left;
+ } else {
+ return n;
}
}
return r;
--
1.5.6.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2008-12-09 10:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-09 10:21 [PATCH 5/6] pkt_sched: sch_htb: Optimize htb_find_next_upper() Jarek Poplawski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).