netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: bazsi@balabit.hu
Cc: netdev@vger.kernel.org, tproxy@lists.balabit.hu,
	hidden@sch.bme.hu, panther@balabit.hu
Subject: Re: [RFC][PATCH] [TPROXY] kick out TIME_WAIT sockets in case a new connection comes in with the same tuple
Date: Wed, 10 Dec 2008 00:57:28 -0800 (PST)	[thread overview]
Message-ID: <20081210.005728.41175879.davem@davemloft.net> (raw)
In-Reply-To: <1228899142.7542.31.camel@bzorp.balabit>

From: Balazs Scheidler <bazsi@balabit.hu>
Date: Wed, 10 Dec 2008 09:52:22 +0100

> I understand. Here are the alternatives I considered:
>  1) the patch above, by extending the socket structures
>  2) expand skb, of course I felt this is worse than the patch I posted
>  3) call inet_twsk_deschedule() from the prerouting hook
> 
> The 3rd one does not require any expansion of the related structures,
> however it'd mean that the TCP state is not only looked up, but also
> changed from the TPROXY target. I felt this ugly, but the ugliness would
> be constrained to the tproxy code. Shall I post a patch implementing
> option #3 above?

It would be interesting to see what it looks like, so if you
don't mind then yes please toss that together so we can have
a look.

  reply	other threads:[~2008-12-10  8:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-09  8:51 [RFC][PATCH] [TPROXY] kick out TIME_WAIT sockets in case a new connection comes in with the same tuple Balazs Scheidler
2008-12-10  6:18 ` David Miller
2008-12-10  8:52   ` Balazs Scheidler
2008-12-10  8:57     ` David Miller [this message]
2008-12-10 10:15       ` Balazs Scheidler
2008-12-10 23:21         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081210.005728.41175879.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bazsi@balabit.hu \
    --cc=hidden@sch.bme.hu \
    --cc=netdev@vger.kernel.org \
    --cc=panther@balabit.hu \
    --cc=tproxy@lists.balabit.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).