From: Jarek Poplawski <jarkao2@gmail.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] netpoll: fix race on poll_list resulting in garbage entry
Date: Thu, 11 Dec 2008 13:07:28 +0000 [thread overview]
Message-ID: <20081211130728.GB5910@ff.dom.local> (raw)
In-Reply-To: <20081209210644.GC3785@hmsreliant.think-freely.org>
On 09-12-2008 22:06, Neil Horman wrote:
...
> When executing napi->poll from the netpoll_path, this bit will
> be set. When a driver calls netif_rx_complete, if that bit is set, it will not
> remove the napi_struct from the poll_list. That work will be saved for the next
> iteration of net_rx_action.
This could be not enough: some drivers, e.g. sky2, call napi_complete()
directly.
Regards,
Jarek P.
next prev parent reply other threads:[~2008-12-11 13:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-09 21:06 [PATCH] netpoll: fix race on poll_list resulting in garbage entry Neil Horman
2008-12-10 7:22 ` David Miller
2008-12-11 13:07 ` Jarek Poplawski [this message]
2008-12-11 14:29 ` Neil Horman
2008-12-11 17:01 ` Stephen Hemminger
2008-12-11 18:15 ` Neil Horman
2008-12-12 0:03 ` Stephen Hemminger
2008-12-12 12:18 ` Neil Horman
2008-12-16 23:55 ` David Miller
2008-12-17 21:16 ` Neil Horman
2008-12-17 21:31 ` Stephen Hemminger
2008-12-17 23:44 ` Neil Horman
2008-12-18 1:13 ` Neil Horman
2008-12-18 3:29 ` David Miller
2008-12-18 14:47 ` Neil Horman
2008-12-18 19:52 ` Neil Horman
2008-12-18 22:40 ` Ben Hutchings
2008-12-18 23:30 ` Johannes Berg
2008-12-19 1:25 ` Neil Horman
2008-12-19 6:42 ` David Miller
2008-12-19 13:42 ` Neil Horman
2008-12-23 4:43 ` David Miller
2008-12-18 9:04 ` Jarek Poplawski
2008-12-12 7:07 ` Jarek Poplawski
2008-12-12 13:31 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081211130728.GB5910@ff.dom.local \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).