From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: shemminger@vyatta.com, jarkao2@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] netpoll: fix race on poll_list resulting in garbage entry
Date: Tue, 16 Dec 2008 15:55:40 -0800 (PST) [thread overview]
Message-ID: <20081216.155540.34452478.davem@davemloft.net> (raw)
In-Reply-To: <20081212121835.GA2402@hmsreliant.think-freely.org>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Fri, 12 Dec 2008 07:18:35 -0500
> On Thu, Dec 11, 2008 at 04:03:07PM -0800, Stephen Hemminger wrote:
> > I would ask it the other way. Why is interface an argument to netif_rx_complete
> > if it is never used?
> >
> Thats a fair question, and I don't know the answer, Dave?
That's just what the old code uses, since the NAPI context
sat inside of the device. I just never removed it.
next prev parent reply other threads:[~2008-12-16 23:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-09 21:06 [PATCH] netpoll: fix race on poll_list resulting in garbage entry Neil Horman
2008-12-10 7:22 ` David Miller
2008-12-11 13:07 ` Jarek Poplawski
2008-12-11 14:29 ` Neil Horman
2008-12-11 17:01 ` Stephen Hemminger
2008-12-11 18:15 ` Neil Horman
2008-12-12 0:03 ` Stephen Hemminger
2008-12-12 12:18 ` Neil Horman
2008-12-16 23:55 ` David Miller [this message]
2008-12-17 21:16 ` Neil Horman
2008-12-17 21:31 ` Stephen Hemminger
2008-12-17 23:44 ` Neil Horman
2008-12-18 1:13 ` Neil Horman
2008-12-18 3:29 ` David Miller
2008-12-18 14:47 ` Neil Horman
2008-12-18 19:52 ` Neil Horman
2008-12-18 22:40 ` Ben Hutchings
2008-12-18 23:30 ` Johannes Berg
2008-12-19 1:25 ` Neil Horman
2008-12-19 6:42 ` David Miller
2008-12-19 13:42 ` Neil Horman
2008-12-23 4:43 ` David Miller
2008-12-18 9:04 ` Jarek Poplawski
2008-12-12 7:07 ` Jarek Poplawski
2008-12-12 13:31 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081216.155540.34452478.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).