* Re: kernel panics with net_rx_action on kernels >2.6.26 [not found] <4945157C.9000305@sbg.ac.at> @ 2008-12-15 6:48 ` David Miller 2008-12-15 13:35 ` Jarek Poplawski 0 siblings, 1 reply; 7+ messages in thread From: David Miller @ 2008-12-15 6:48 UTC (permalink / raw) To: alexander.huemer; +Cc: linux-net, netdev From: Alexander Huemer <alexander.huemer@sbg.ac.at> Date: Sun, 14 Dec 2008 15:17:32 +0100 Networking developers generally don't read the linux-net list, it is for user configuration and basic questions only, not bug reports or technical discussions. netdev is the place to report such things, and I've added that to the CC: > one of my machines (x86) crashes under heavy network load with kernels > >2.6.26, i tried quite everything possible between 2.6.27 and 2.6.28-rc8. > > lspci -vv: http://xx.vu/~ahuemer/lspci_vv.txt <http://xx.vu/%7Eahuemer/lspci_vv.txt> > of the quad nic 2 ports are used, the machine is acting as a iptables > firewall/router. > > kernel config (2.6.26) http://xx.vu/~ahuemer/config <http://xx.vu/%7Eahuemer/config> > screenshot of the panic: > http://xx.vu/~ahuemer/kernel_panic_net_rx_action.jpg <http://xx.vu/%7Eahuemer/kernel_panic_net_rx_action.jpg> > > as i do not have any problems with kernels <=2.6.26, i doubt that this > is a hardware problem. > in case of the panic, nothing is written to the system log. > > any hints welcome. > please CC me on replies, i am not subscribed to the mailing list. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: kernel panics with net_rx_action on kernels >2.6.26 2008-12-15 6:48 ` kernel panics with net_rx_action on kernels >2.6.26 David Miller @ 2008-12-15 13:35 ` Jarek Poplawski 2008-12-15 20:11 ` Alexander Huemer 2008-12-16 9:22 ` David Miller 0 siblings, 2 replies; 7+ messages in thread From: Jarek Poplawski @ 2008-12-15 13:35 UTC (permalink / raw) To: David Miller; +Cc: alexander.huemer, linux-net, netdev On 15-12-2008 07:48, David Miller wrote: > From: Alexander Huemer <alexander.huemer@sbg.ac.at> > Date: Sun, 14 Dec 2008 15:17:32 +0100 > > Networking developers generally don't read the linux-net list, it is > for user configuration and basic questions only, not bug reports or > technical discussions. > > netdev is the place to report such things, and I've added that to the > CC: > >> one of my machines (x86) crashes under heavy network load with kernels >>> 2.6.26, i tried quite everything possible between 2.6.27 and 2.6.28-rc8. >> lspci -vv: http://xx.vu/~ahuemer/lspci_vv.txt <http://xx.vu/%7Eahuemer/lspci_vv.txt> >> of the quad nic 2 ports are used, the machine is acting as a iptables >> firewall/router. >> >> kernel config (2.6.26) http://xx.vu/~ahuemer/config <http://xx.vu/%7Eahuemer/config> >> screenshot of the panic: >> http://xx.vu/~ahuemer/kernel_panic_net_rx_action.jpg <http://xx.vu/%7Eahuemer/kernel_panic_net_rx_action.jpg> >> >> as i do not have any problems with kernels <=2.6.26, i doubt that this >> is a hardware problem. >> in case of the panic, nothing is written to the system log. >> >> any hints welcome. >> please CC me on replies, i am not subscribed to the mailing list. Could you try this patch, please? Jarek P. --- drivers/net/starfire.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/net/starfire.c b/drivers/net/starfire.c index 0358809..f86d6bb 100644 --- a/drivers/net/starfire.c +++ b/drivers/net/starfire.c @@ -1503,6 +1503,11 @@ static int __netdev_rx(struct net_device *dev, int *quota) desc->status = 0; np->rx_done = (np->rx_done + 1) % DONE_Q_SIZE; } + + if (*quota == 0) { /* out of rx quota */ + retcode = 1; + goto out; + } writew(np->rx_done, np->base + CompletionQConsumerIdx); out: ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: kernel panics with net_rx_action on kernels >2.6.26 2008-12-15 13:35 ` Jarek Poplawski @ 2008-12-15 20:11 ` Alexander Huemer 2008-12-16 6:59 ` Jarek Poplawski 2008-12-16 9:22 ` David Miller 1 sibling, 1 reply; 7+ messages in thread From: Alexander Huemer @ 2008-12-15 20:11 UTC (permalink / raw) To: Jarek Poplawski; +Cc: David Miller, linux-net, netdev Jarek Poplawski wrote: > On 15-12-2008 07:48, David Miller wrote: > >> From: Alexander Huemer <alexander.huemer@sbg.ac.at> >> Date: Sun, 14 Dec 2008 15:17:32 +0100 >> >> Networking developers generally don't read the linux-net list, it is >> for user configuration and basic questions only, not bug reports or >> technical discussions. >> >> netdev is the place to report such things, and I've added that to the >> CC: >> >> >>> one of my machines (x86) crashes under heavy network load with kernels >>> >>>> 2.6.26, i tried quite everything possible between 2.6.27 and 2.6.28-rc8. >>>> >>> lspci -vv: http://xx.vu/~ahuemer/lspci_vv.txt <http://xx.vu/%7Eahuemer/lspci_vv.txt> >>> of the quad nic 2 ports are used, the machine is acting as a iptables >>> firewall/router. >>> >>> kernel config (2.6.26) http://xx.vu/~ahuemer/config <http://xx.vu/%7Eahuemer/config> >>> screenshot of the panic: >>> http://xx.vu/~ahuemer/kernel_panic_net_rx_action.jpg <http://xx.vu/%7Eahuemer/kernel_panic_net_rx_action.jpg> >>> >>> as i do not have any problems with kernels <=2.6.26, i doubt that this >>> is a hardware problem. >>> in case of the panic, nothing is written to the system log. >>> >>> any hints welcome. >>> please CC me on replies, i am not subscribed to the mailing list. >>> > > Could you try this patch, please? > > Jarek P. > --- > > drivers/net/starfire.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/starfire.c b/drivers/net/starfire.c > index 0358809..f86d6bb 100644 > --- a/drivers/net/starfire.c > +++ b/drivers/net/starfire.c > @@ -1503,6 +1503,11 @@ static int __netdev_rx(struct net_device *dev, int *quota) > desc->status = 0; > np->rx_done = (np->rx_done + 1) % DONE_Q_SIZE; > } > + > + if (*quota == 0) { /* out of rx quota */ > + retcode = 1; > + goto out; > + } > writew(np->rx_done, np->base + CompletionQConsumerIdx); > > out: > thanks for the patch, jarek. i applied it to 2.6.28-rc8. the machine is already running under heavy network load, as before, when the panics occur. heavy load means high packets/second values, not high byte/second values. if you find that necessary for testing i will find a way to pump some gigs through the machine. let's see what happens. i will get back to you after a new panic or 2 days without panic. -- kind regards alex. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: kernel panics with net_rx_action on kernels >2.6.26 2008-12-15 20:11 ` Alexander Huemer @ 2008-12-16 6:59 ` Jarek Poplawski 0 siblings, 0 replies; 7+ messages in thread From: Jarek Poplawski @ 2008-12-16 6:59 UTC (permalink / raw) To: Alexander Huemer; +Cc: David Miller, linux-net, netdev On Mon, Dec 15, 2008 at 09:11:09PM +0100, Alexander Huemer wrote: ... > i applied it to 2.6.28-rc8. > the machine is already running under heavy network load, as before, when > the panics occur. > heavy load means high packets/second values, not high byte/second values. > if you find that necessary for testing i will find a way to pump some > gigs through the machine. > let's see what happens. Actually, the bug I trie to fix in this patch doesn't depend on heavy load directly, but on counting: it should trigger after receiving 20 packets (or max_interrupt_work driver parameter if you use this), and then some break. > i will get back to you after a new panic or 2 days without panic. Regards, Jarek P. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: kernel panics with net_rx_action on kernels >2.6.26 2008-12-15 13:35 ` Jarek Poplawski 2008-12-15 20:11 ` Alexander Huemer @ 2008-12-16 9:22 ` David Miller 2008-12-16 14:06 ` [PATCH] " Jarek Poplawski 1 sibling, 1 reply; 7+ messages in thread From: David Miller @ 2008-12-16 9:22 UTC (permalink / raw) To: jarkao2; +Cc: alexander.huemer, linux-net, netdev From: Jarek Poplawski <jarkao2@gmail.com> Date: Mon, 15 Dec 2008 13:35:21 +0000 > Could you try this patch, please? ... > @@ -1503,6 +1503,11 @@ static int __netdev_rx(struct net_device *dev, int *quota) > desc->status = 0; > np->rx_done = (np->rx_done + 1) % DONE_Q_SIZE; > } > + > + if (*quota == 0) { /* out of rx quota */ > + retcode = 1; > + goto out; > + } > writew(np->rx_done, np->base + CompletionQConsumerIdx); > > out: Jarek this looks good and it looks to be tested as well. Could you formally submit this? Thanks. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Re: kernel panics with net_rx_action on kernels >2.6.26 2008-12-16 9:22 ` David Miller @ 2008-12-16 14:06 ` Jarek Poplawski 2008-12-16 23:42 ` David Miller 0 siblings, 1 reply; 7+ messages in thread From: Jarek Poplawski @ 2008-12-16 14:06 UTC (permalink / raw) To: Jeff Garzik, David Miller; +Cc: Alexander Huemer, linux-net, netdev On Tue, Dec 16, 2008 at 01:22:47AM -0800, David Miller wrote: ... > Jarek this looks good and it looks to be tested as well. > > Could you formally submit this? -------------------> drivers/net: starfire: Fix napi ->poll() weight handling starfire napi ->poll() handler can return work == weight after calling netif_rx_complete() (if there is no more work). It is illegal and this patch fixes it. Reported-by: Alexander Huemer <alexander.huemer@sbg.ac.at> Tested-by: Alexander Huemer <alexander.huemer@sbg.ac.at> Signed-off-by: Jarek Poplawski <jarkao2@gmail.com> --- drivers/net/starfire.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/net/starfire.c b/drivers/net/starfire.c index 0358809..f86d6bb 100644 --- a/drivers/net/starfire.c +++ b/drivers/net/starfire.c @@ -1503,6 +1503,11 @@ static int __netdev_rx(struct net_device *dev, int *quota) desc->status = 0; np->rx_done = (np->rx_done + 1) % DONE_Q_SIZE; } + + if (*quota == 0) { /* out of rx quota */ + retcode = 1; + goto out; + } writew(np->rx_done, np->base + CompletionQConsumerIdx); out: ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Re: kernel panics with net_rx_action on kernels >2.6.26 2008-12-16 14:06 ` [PATCH] " Jarek Poplawski @ 2008-12-16 23:42 ` David Miller 0 siblings, 0 replies; 7+ messages in thread From: David Miller @ 2008-12-16 23:42 UTC (permalink / raw) To: jarkao2; +Cc: jgarzik, alexander.huemer, linux-net, netdev From: Jarek Poplawski <jarkao2@gmail.com> Date: Tue, 16 Dec 2008 14:06:51 +0000 > drivers/net: starfire: Fix napi ->poll() weight handling > > starfire napi ->poll() handler can return work == weight after calling > netif_rx_complete() (if there is no more work). It is illegal and this > patch fixes it. > > Reported-by: Alexander Huemer <alexander.huemer@sbg.ac.at> > Tested-by: Alexander Huemer <alexander.huemer@sbg.ac.at> > Signed-off-by: Jarek Poplawski <jarkao2@gmail.com> Applied, thanks everyone. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-12-16 23:42 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4945157C.9000305@sbg.ac.at>
2008-12-15 6:48 ` kernel panics with net_rx_action on kernels >2.6.26 David Miller
2008-12-15 13:35 ` Jarek Poplawski
2008-12-15 20:11 ` Alexander Huemer
2008-12-16 6:59 ` Jarek Poplawski
2008-12-16 9:22 ` David Miller
2008-12-16 14:06 ` [PATCH] " Jarek Poplawski
2008-12-16 23:42 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).