From: Andrew Morton <akpm@linux-foundation.org>
To: Steve Glendinning <steve.glendinning@smsc.com>
Cc: netdev@vger.kernel.org, ian.saturley@smsc.com,
steve.glendinning@smsc.com
Subject: Re: [RFC PATCH 1/2] move flow control definitions to mii.h
Date: Wed, 17 Dec 2008 16:17:08 -0800 [thread overview]
Message-ID: <20081217161708.cb83783c.akpm@linux-foundation.org> (raw)
In-Reply-To: <1229258301-5073-2-git-send-email-steve.glendinning@smsc.com>
On Sun, 14 Dec 2008 12:38:20 +0000
Steve Glendinning <steve.glendinning@smsc.com> wrote:
> flags used within drivers for indicating tx and rx flow control are
> defined in 4 drivers (and probably more), move these constants to mii.h.
>
> The 3 SMSC drivers use the same constants (FLOW_CTRL_TX), but TG3 uses
> TG3_FLOW_CTRL_TX, so this patch also renames the constants within TG3.
>
> Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
> ---
> drivers/net/smsc911x.h | 3 --
> drivers/net/smsc9420.h | 3 --
> drivers/net/tg3.c | 50 ++++++++++++++++++++++----------------------
> drivers/net/tg3.h | 2 -
> drivers/net/usb/smsc95xx.c | 2 -
> include/linux/mii.h | 4 +++
In file included from drivers/net/bnx2.c:52:
drivers/net/bnx2.h:6851:1: warning: "FLOW_CTRL_TX" redefined
In file included from drivers/net/bnx2.c:37:
include/linux/mii.h:139:1: warning: this is the location of the previous definition
In file included from drivers/net/bnx2.c:52:
drivers/net/bnx2.h:6852:1: warning: "FLOW_CTRL_RX" redefined
There are unfixed definitions of FLOW_CTRL_TX in drivers/net/bnx2.h and
drivers/net/bnx2x_link.h.
next prev parent reply other threads:[~2008-12-18 0:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-14 12:38 [RFC PATCH 0/2] unify full duplex flow control resolution Steve Glendinning
2008-12-14 12:38 ` [RFC PATCH 1/2] move flow control definitions to mii.h Steve Glendinning
2008-12-14 12:38 ` [RFC PATCH 2/2] refactor full duplex flow control resolution Steve Glendinning
2008-12-16 10:00 ` David Miller
2008-12-23 17:45 ` Ben Hutchings
2008-12-29 17:12 ` Steve.Glendinning
2008-12-16 10:00 ` [RFC PATCH 1/2] move flow control definitions to mii.h David Miller
2008-12-18 0:17 ` Andrew Morton [this message]
2008-12-18 0:27 ` David Miller
2008-12-23 17:47 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081217161708.cb83783c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ian.saturley@smsc.com \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).