From: David Miller <davem@davemloft.net>
To: yjwei@cn.fujitsu.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: Fix module refcount leak in kernel_accept()
Date: Thu, 18 Dec 2008 19:35:27 -0800 (PST) [thread overview]
Message-ID: <20081218.193527.239071578.davem@davemloft.net> (raw)
In-Reply-To: <494A23FE.6020305@cn.fujitsu.com>
From: Wei Yongjun <yjwei@cn.fujitsu.com>
Date: Thu, 18 Dec 2008 18:20:46 +0800
> The kernel_accept() does not hold the module refcount of newsock->ops->owner,
> so we need __module_get(newsock->ops->owner) code after call kernel_accept()
> by hand.
> In sunrpc, the module refcount is missing to hold. So this cause kernel panic.
>
> Used following script to reproduct:
...
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Good fine, patch applied, thanks!
next prev parent reply other threads:[~2008-12-19 3:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 10:20 [PATCH] net: Fix module refcount leak in kernel_accept() Wei Yongjun
2008-12-19 3:35 ` David Miller [this message]
2008-12-19 6:35 ` Marcel Holtmann
2008-12-19 6:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081218.193527.239071578.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).