From: David Miller <davem@davemloft.net>
To: gerrit@erg.abdn.ac.uk
Cc: acme@ghostprotocols.net, mirqus@gmail.com, dccp@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [RFCv2][PATCH] static builtin CCIDs was Re: [PATCH 2/5] dccp: Auto-load (when supported) CCID plugins for negotiation
Date: Thu, 18 Dec 2008 22:28:42 -0800 (PST) [thread overview]
Message-ID: <20081218.222842.174783235.davem@davemloft.net> (raw)
In-Reply-To: <20081219052446.GA3651@gerrit.erg.abdn.ac.uk>
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Fri, 19 Dec 2008 06:24:46 +0100
> | > | Gerrit, are you OK with this?
> | > |
> | > Acked-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
> |
> | Applied, thanks everyone.
> |
> I am sorry but I have to revert the Acked-by. As per
> yesterday's email I was ok with the basic idea, but
> already said that this did not include testing.
>
> Please do not apply this patch yet, it introduces several
> new problems and needs more work.
You are so incredibly lucky I didn't push this out to kernel.org yet,
it's been sitting in my tree all day long.
Don't say ACK unless you mean it.
It's reverted but you should do real reviews before you ACK changes in
the future.
next prev parent reply other threads:[~2008-12-19 6:28 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 21:46 [RFCv2][PATCH] static builtin CCIDs was Re: [PATCH 2/5] dccp: Auto-load (when supported) CCID plugins for negotiation Arnaldo Carvalho de Melo
2008-12-18 5:21 ` David Miller
2008-12-18 5:33 ` Gerrit Renker
2008-12-19 3:15 ` David Miller
2008-12-19 5:24 ` Gerrit Renker
2008-12-19 6:28 ` David Miller [this message]
2008-12-19 7:56 ` gerrit
2008-12-20 23:51 ` Arnaldo Carvalho de Melo
2008-12-20 8:08 ` [RFC] [Patch 0/4] dccp: Working prototype of integrating the modules Gerrit Renker
2008-12-20 8:08 ` [RFC] [Patch 1/4] dccp: Remove old CCID-module references Gerrit Renker
2008-12-20 8:08 ` [RFC] [Patch 2/4] dccp: Lockless use of CCID blocks Gerrit Renker
2008-12-21 0:32 ` Arnaldo Carvalho de Melo
2008-12-23 17:08 ` Gerrit Renker
2008-12-23 17:17 ` Gerrit Renker
2009-01-01 10:49 ` Gerrit Renker
2009-01-03 7:30 ` [Patch 0/3] " Gerrit Renker
2009-01-03 7:30 ` [PATCH 1/3] dccp: Lockless integration of CCID congestion-control plugins Gerrit Renker
2009-01-03 7:30 ` [PATCH 2/3] dccp: Clean up ccid.c after integration of CCID plugins Gerrit Renker
2009-01-03 7:30 ` [PATCH 3/3] dccp: Integrate the TFRC library with DCCP Gerrit Renker
2009-01-05 5:46 ` David Miller
2009-01-17 9:36 ` [PATCH 0/4] dccp: Completing feature negotiation Gerrit Renker
2009-01-17 9:36 ` [PATCH 1/4] dccp: Initialisation framework for " Gerrit Renker
2009-01-17 9:36 ` [PATCH 2/4] dccp: Implement both feature-local and feature-remote Sequence Window feature Gerrit Renker
2009-01-17 9:36 ` [PATCH 3/4] dccp: Initialisation and type-checking of feature sysctls Gerrit Renker
2009-01-17 9:36 ` [PATCH 4/4] dccp: Debugging functions for feature negotiation Gerrit Renker
2009-01-19 5:40 ` David Miller
2009-01-19 5:40 ` [PATCH 3/4] dccp: Initialisation and type-checking of feature sysctls David Miller
2009-01-19 5:40 ` [PATCH 2/4] dccp: Implement both feature-local and feature-remote Sequence Window feature David Miller
2009-01-19 5:39 ` [PATCH 1/4] dccp: Initialisation framework for feature negotiation David Miller
2009-01-05 5:46 ` [PATCH 2/3] dccp: Clean up ccid.c after integration of CCID plugins David Miller
2009-01-05 5:45 ` [PATCH 1/3] dccp: Lockless integration of CCID congestion-control plugins David Miller
2008-12-20 8:08 ` [RFC] [Patch 3/4] dccp: Add unregister function Gerrit Renker
2008-12-21 0:35 ` Arnaldo Carvalho de Melo
2008-12-20 8:08 ` [RFC] [Patch 4/4] dccp: Integrate the TFRC library (dependency) Gerrit Renker
2008-12-21 0:55 ` Arnaldo Carvalho de Melo
2008-12-23 10:54 ` Gerrit Renker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081218.222842.174783235.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@ghostprotocols.net \
--cc=dccp@vger.kernel.org \
--cc=gerrit@erg.abdn.ac.uk \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).