netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH 7/8] skge: set VPD size
Date: Wed, 17 Dec 2008 16:01:51 -0800	[thread overview]
Message-ID: <20081218000241.397407939@vyatta.com> (raw)
In-Reply-To: 20081218000144.964015472@vyatta.com

[-- Attachment #1: skge-vpd-size.patch --]
[-- Type: text/plain, Size: 1130 bytes --]

Read configuration register during probe and use it to size the
available VPD.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

--- a/drivers/net/skge.c	2008-11-24 08:50:54.000000000 -0800
+++ b/drivers/net/skge.c	2008-11-24 08:50:58.000000000 -0800
@@ -3980,6 +3980,7 @@ static int __devinit skge_probe(struct p
 	struct net_device *dev, *dev1;
 	struct skge_hw *hw;
 	int err, using_dac = 0;
+	u32 reg;
 
 	err = pci_enable_device(pdev);
 	if (err) {
@@ -4008,15 +4009,17 @@ static int __devinit skge_probe(struct p
 		goto err_out_free_regions;
 	}
 
+	pci_read_config_dword(pdev, PCI_DEV_REG2, &reg);
+
+	/* set size of available VPD, only impacts sysfs */
+	err = pci_vpd_truncate(pdev, 1ul << (((reg & PCI_VPD_ROM_SZ) >> 14) + 8));
+	if (err)
+		dev_warn(&pdev->dev, "Can't set VPD size\n");
+
 #ifdef __BIG_ENDIAN
 	/* byte swap descriptors in hardware */
-	{
-		u32 reg;
-
-		pci_read_config_dword(pdev, PCI_DEV_REG2, &reg);
-		reg |= PCI_REV_DESC;
-		pci_write_config_dword(pdev, PCI_DEV_REG2, reg);
-	}
+	reg |= PCI_REV_DESC;
+	pci_write_config_dword(pdev, PCI_DEV_REG2, reg);
 #endif
 
 	err = -ENOMEM;

-- 


  parent reply	other threads:[~2008-12-18  0:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-18  0:01 [PATCH 0/8] skge/sky2 patches for net-next Stephen Hemminger
2008-12-18  0:01 ` [PATCH 1/8] PCI: vpd handle longer delays in access (rev4) Stephen Hemminger
2008-12-18  0:01 ` [PATCH 2/8] PCI: revise VPD access interface (rev3) Stephen Hemminger
2008-12-18  0:01 ` [PATCH 3/8] PCI: add interface to set visible size of VPD (rev3) Stephen Hemminger
2008-12-18  0:01 ` [PATCH 4/8] sky2: move VPD display into debug interface Stephen Hemminger
2008-12-18  0:01 ` [PATCH 5/8] sky2: set VPD size Stephen Hemminger
2008-12-18  0:01 ` [PATCH 6/8] skge: add VPD display into debug interface Stephen Hemminger
2008-12-18  0:01 ` Stephen Hemminger [this message]
2008-12-18  0:01 ` [PATCH 8/8] sky2: handle dma mapping errors Stephen Hemminger
2008-12-18  3:33 ` [PATCH 0/8] skge/sky2 patches for net-next David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081218000241.397407939@vyatta.com \
    --to=shemminger@vyatta.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).