From: Oliver Neukum <oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
To: ajb-5+cxppFmGx6/3pe1ocb+s/XRex20P6io@public.gmane.org,
"Greg Kroah-Hartman" <gregkh-l3A5Bk7waGM@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jgarzik-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org,
USB list <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [patch]startup race in hso driver
Date: Thu, 18 Dec 2008 14:57:35 +0100 [thread overview]
Message-ID: <200812181457.36340.oliver@neukum.org> (raw)
The flag marking a device running must be set before the URBs for
recption are submitted or they may complete too early and fail to resubmit.
Signed-off-by: Oliver Neukum <oneukum-l3A5Bk7waGM@public.gmane.org>
Regards
Oliver
---
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index 8e90891..cc75c8b 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -658,10 +658,9 @@ static int hso_net_open(struct net_device *net)
odev->rx_buf_missing = sizeof(struct iphdr);
spin_unlock_irqrestore(&odev->net_lock, flags);
- hso_start_net_device(odev->parent);
next reply other threads:[~2008-12-18 13:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 13:57 Oliver Neukum [this message]
[not found] ` <200812181457.36340.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-12-18 13:59 ` [patch]startup race in hso driver Denis Joseph Barrow
[not found] ` <494A5728.9070908-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
2008-12-19 3:52 ` David Miller
[not found] ` <20081218.195251.186334055.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-12-19 9:20 ` Denis Joseph Barrow
2008-12-23 3:54 ` David Miller
[not found] ` <20081222.195420.82285555.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-12-23 12:33 ` Oliver Neukum
2008-12-19 3:45 ` David Miller
2009-01-12 10:03 ` Denis Joseph Barrow
[not found] ` <496B1556.3010901-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
2009-01-12 10:57 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812181457.36340.oliver@neukum.org \
--to=oliver-gvhc2dphhpqdnm+yrofe0a@public.gmane.org \
--cc=ajb-5+cxppFmGx6/3pe1ocb+s/XRex20P6io@public.gmane.org \
--cc=gregkh-l3A5Bk7waGM@public.gmane.org \
--cc=jgarzik-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).