* [PATCH] net: Fix oops in dev_ifsioc()
@ 2008-12-19 7:04 Jarek Poplawski
2008-12-19 8:02 ` Wang Chen
2008-12-23 3:35 ` David Miller
0 siblings, 2 replies; 6+ messages in thread
From: Jarek Poplawski @ 2008-12-19 7:04 UTC (permalink / raw)
To: David Miller; +Cc: netdev
A command like this: "brctl addif br1 eth1" issued as a user gave me
an oops when bridge module wasn't loaded. It's caused by using a dev
pointer before checking for NULL.
Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
---
net/core/dev.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 048cf11..daca72e 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -3745,11 +3745,13 @@ static int dev_ifsioc(struct net *net, struct ifreq *ifr, unsigned int cmd)
{
int err;
struct net_device *dev = __dev_get_by_name(net, ifr->ifr_name);
- const struct net_device_ops *ops = dev->netdev_ops;
+ const struct net_device_ops *ops;
if (!dev)
return -ENODEV;
+ ops = dev->netdev_ops;
+
switch (cmd) {
case SIOCSIFFLAGS: /* Set interface flags */
return dev_change_flags(dev, ifr->ifr_flags);
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] net: Fix oops in dev_ifsioc()
2008-12-19 7:04 [PATCH] net: Fix oops in dev_ifsioc() Jarek Poplawski
@ 2008-12-19 8:02 ` Wang Chen
2008-12-19 8:11 ` Jarek Poplawski
2008-12-23 3:35 ` David Miller
1 sibling, 1 reply; 6+ messages in thread
From: Wang Chen @ 2008-12-19 8:02 UTC (permalink / raw)
To: julia; +Cc: Jarek Poplawski, David Miller, netdev
Jarek Poplawski said the following on 2008-12-19 15:04:
> A command like this: "brctl addif br1 eth1" issued as a user gave me
> an oops when bridge module wasn't loaded. It's caused by using a dev
> pointer before checking for NULL.
>
> Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
> ---
>
> net/core/dev.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 048cf11..daca72e 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -3745,11 +3745,13 @@ static int dev_ifsioc(struct net *net, struct ifreq *ifr, unsigned int cmd)
> {
> int err;
> struct net_device *dev = __dev_get_by_name(net, ifr->ifr_name);
> - const struct net_device_ops *ops = dev->netdev_ops;
> + const struct net_device_ops *ops;
>
> if (!dev)
> return -ENODEV;
>
> + ops = dev->netdev_ops;
> +
> switch (cmd) {
> case SIOCSIFFLAGS: /* Set interface flags */
> return dev_change_flags(dev, ifr->ifr_flags);
Subject will be changed, sorry.
Seems Julia is doing "Move a dereference below a NULL test" check,
but why the coccinelle missed this one?
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] net: Fix oops in dev_ifsioc()
2008-12-19 8:02 ` Wang Chen
@ 2008-12-19 8:11 ` Jarek Poplawski
2008-12-19 8:14 ` Wang Chen
0 siblings, 1 reply; 6+ messages in thread
From: Jarek Poplawski @ 2008-12-19 8:11 UTC (permalink / raw)
To: Wang Chen; +Cc: julia, David Miller, netdev
On Fri, Dec 19, 2008 at 04:02:51PM +0800, Wang Chen wrote:
> Jarek Poplawski said the following on 2008-12-19 15:04:
> > A command like this: "brctl addif br1 eth1" issued as a user gave me
> > an oops when bridge module wasn't loaded. It's caused by using a dev
> > pointer before checking for NULL.
...
> Subject will be changed, sorry.
> Seems Julia is doing "Move a dereference below a NULL test" check,
> but why the coccinelle missed this one?
Probably because it's quite fresh?
Jarek P.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net: Fix oops in dev_ifsioc()
2008-12-19 8:11 ` Jarek Poplawski
@ 2008-12-19 8:14 ` Wang Chen
2008-12-19 8:33 ` Julia Lawall
0 siblings, 1 reply; 6+ messages in thread
From: Wang Chen @ 2008-12-19 8:14 UTC (permalink / raw)
To: Jarek Poplawski; +Cc: julia, David Miller, netdev
Jarek Poplawski said the following on 2008-12-19 16:11:
> On Fri, Dec 19, 2008 at 04:02:51PM +0800, Wang Chen wrote:
>> Jarek Poplawski said the following on 2008-12-19 15:04:
>>> A command like this: "brctl addif br1 eth1" issued as a user gave me
>>> an oops when bridge module wasn't loaded. It's caused by using a dev
>>> pointer before checking for NULL.
> ...
>> Subject will be changed, sorry.
>> Seems Julia is doing "Move a dereference below a NULL test" check,
>> but why the coccinelle missed this one?
>
> Probably because it's quite fresh?
>
Yes. Maybe Julia never check the source of -next. :)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net: Fix oops in dev_ifsioc()
2008-12-19 8:14 ` Wang Chen
@ 2008-12-19 8:33 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2008-12-19 8:33 UTC (permalink / raw)
To: Wang Chen; +Cc: Jarek Poplawski, David Miller, netdev
On Fri, 19 Dec 2008, Wang Chen wrote:
> Jarek Poplawski said the following on 2008-12-19 16:11:
> > On Fri, Dec 19, 2008 at 04:02:51PM +0800, Wang Chen wrote:
> >> Jarek Poplawski said the following on 2008-12-19 15:04:
> >>> A command like this: "brctl addif br1 eth1" issued as a user gave me
> >>> an oops when bridge module wasn't loaded. It's caused by using a dev
> >>> pointer before checking for NULL.
> > ...
> >> Subject will be changed, sorry.
> >> Seems Julia is doing "Move a dereference below a NULL test" check,
> >> but why the coccinelle missed this one?
> >
> > Probably because it's quite fresh?
> >
>
> Yes. Maybe Julia never check the source of -next. :)
Sorry, my -next was mysteriously quite out of date. It's up to date now.
Indeed, I found that one just now.
julia
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net: Fix oops in dev_ifsioc()
2008-12-19 7:04 [PATCH] net: Fix oops in dev_ifsioc() Jarek Poplawski
2008-12-19 8:02 ` Wang Chen
@ 2008-12-23 3:35 ` David Miller
1 sibling, 0 replies; 6+ messages in thread
From: David Miller @ 2008-12-23 3:35 UTC (permalink / raw)
To: jarkao2; +Cc: netdev
From: Jarek Poplawski <jarkao2@gmail.com>
Date: Fri, 19 Dec 2008 07:04:31 +0000
> A command like this: "brctl addif br1 eth1" issued as a user gave me
> an oops when bridge module wasn't loaded. It's caused by using a dev
> pointer before checking for NULL.
>
> Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Applied, thanks Jarek.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-12-23 3:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-19 7:04 [PATCH] net: Fix oops in dev_ifsioc() Jarek Poplawski
2008-12-19 8:02 ` Wang Chen
2008-12-19 8:11 ` Jarek Poplawski
2008-12-19 8:14 ` Wang Chen
2008-12-19 8:33 ` Julia Lawall
2008-12-23 3:35 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).