From: Ron Mercer <ron.mercer@qlogic.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 3/5] qlge: bugfix: Fix endian issue regarding shadow registers.
Date: Wed, 24 Dec 2008 10:42:20 -0800 [thread overview]
Message-ID: <20081224184220.GA15640@susedev.qlogic.org> (raw)
In-Reply-To: <1230143731.3070.2.camel@achroite>
On Wed, Dec 24, 2008 at 10:35:31AM -0800, Ben Hutchings wrote:
> > +static inline u32 ql_read_sh_reg(const volatile void *addr)
> > {
> > - return *(volatile unsigned int __force *)addr;
> > + return le32_to_cpu(*(volatile unsigned int __force *)addr);
>
> I think that should be:
> return le32_to_cpu(*(const volatile __le32 *)addr);
>
> Ben.
Yes, you're right. I'll fix that and resend the patches after waiting
for more feedback.
Thanks!
next prev parent reply other threads:[~2008-12-24 18:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-24 18:18 [PATCH 0/5] qlge: Fixes for powerpc platform Ron Mercer
2008-12-24 18:21 ` [PATCH 1/5] qlge: bugfux: Add missing pci_mapping_err checking Ron Mercer
2008-12-24 18:21 ` [PATCH 2/5] qlge: bugfix: Add missing pci_unmap_page call in receive path Ron Mercer
2008-12-24 18:21 ` [PATCH 3/5] qlge: bugfix: Fix endian issue regarding shadow registers Ron Mercer
2008-12-24 18:35 ` Ben Hutchings
2008-12-24 18:42 ` Ron Mercer [this message]
2008-12-24 21:15 ` Christoph Hellwig
2008-12-24 21:29 ` Ron Mercer
2008-12-24 21:57 ` Harvey Harrison
2008-12-24 18:21 ` [PATCH 4/5] qlge: bugfix: Fix rx ring and large and small rx buffer length settings Ron Mercer
2008-12-24 18:21 ` [PATCH 5/5] qlge: bugfix: Fix register access error checking Ron Mercer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081224184220.GA15640@susedev.qlogic.org \
--to=ron.mercer@qlogic.com \
--cc=bhutchings@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).