* [PATCH] forcedeth: don't poll NV event 36
@ 2008-12-21 19:44 Johannes Berg
2008-12-26 2:08 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2008-12-21 19:44 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, Ayaz Abdulla, Arjan van de Ven, Manfred Spraul
Polling doesn't seem to be necessary on my hardware, at
least I haven't seen any bad effects testing it a while.
Remove the polling so the CPU doesn't have to wake up a
hundred times per second.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
drivers/net/forcedeth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- wireless-testing.orig/drivers/net/forcedeth.c 2008-12-21 13:01:14.000000000 +0100
+++ wireless-testing/drivers/net/forcedeth.c 2008-12-21 13:02:24.000000000 +0100
@@ -6141,7 +6141,7 @@ static struct pci_device_id pci_tbl[] =
},
{ /* MCP79 Ethernet Controller */
PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NVENET_36),
- .driver_data = DEV_NEED_TIMERIRQ|DEV_NEED_LINKTIMER|DEV_HAS_LARGEDESC|DEV_HAS_CHECKSUM|DEV_HAS_HIGH_DMA|DEV_HAS_MSI|DEV_HAS_POWER_CNTRL|DEV_HAS_PAUSEFRAME_TX_V3|DEV_HAS_STATISTICS_V3|DEV_HAS_TEST_EXTENDED|DEV_HAS_MGMT_UNIT|DEV_HAS_CORRECT_MACADDR|DEV_HAS_COLLISION_FIX|DEV_NEED_TX_LIMIT|DEV_HAS_GEAR_MODE,
+ .driver_data = DEV_NEED_LINKTIMER|DEV_HAS_LARGEDESC|DEV_HAS_CHECKSUM|DEV_HAS_HIGH_DMA|DEV_HAS_MSI|DEV_HAS_POWER_CNTRL|DEV_HAS_PAUSEFRAME_TX_V3|DEV_HAS_STATISTICS_V3|DEV_HAS_TEST_EXTENDED|DEV_HAS_MGMT_UNIT|DEV_HAS_CORRECT_MACADDR|DEV_HAS_COLLISION_FIX|DEV_NEED_TX_LIMIT|DEV_HAS_GEAR_MODE,
},
{ /* MCP79 Ethernet Controller */
PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NVENET_37),
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] forcedeth: don't poll NV event 36
2008-12-21 19:44 [PATCH] forcedeth: don't poll NV event 36 Johannes Berg
@ 2008-12-26 2:08 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-12-26 2:08 UTC (permalink / raw)
To: johannes; +Cc: netdev, aabdulla, arjan, manfred
From: Johannes Berg <johannes@sipsolutions.net>
Date: Sun, 21 Dec 2008 20:44:06 +0100
> Polling doesn't seem to be necessary on my hardware, at
> least I haven't seen any bad effects testing it a while.
> Remove the polling so the CPU doesn't have to wake up a
> hundred times per second.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Applied, thanks Johannes.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-26 2:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-21 19:44 [PATCH] forcedeth: don't poll NV event 36 Johannes Berg
2008-12-26 2:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).